Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: webkit/default_plugin/plugin_impl.cc

Issue 10650: Pass in SW_SHOW to ShellExecuteEx as the plugin installers can rely on this... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/default_plugin/plugin_impl.cc
===================================================================
--- webkit/default_plugin/plugin_impl.cc (revision 5246)
+++ webkit/default_plugin/plugin_impl.cc (working copy)
@@ -618,10 +618,15 @@
std::wstring file_path =
reinterpret_cast<const wchar_t*>(download_file_info->lpData);
+ std::wstring current_directory =
+ file_util::GetDirectoryFromPath(file_path);
+
SHELLEXECUTEINFO shell_execute_info = {0};
shell_execute_info.cbSize = sizeof(shell_execute_info);
shell_execute_info.fMask = SEE_MASK_NOCLOSEPROCESS;
shell_execute_info.lpFile = file_path.c_str();
+ shell_execute_info.lpDirectory = current_directory.c_str();
+ shell_execute_info.nShow = SW_SHOW;
if (!ShellExecuteEx(&shell_execute_info)) {
DLOG(WARNING) << "Failed to launch plugin installer "
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698