Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 10641006: Use nv contrl x extension to query nvidia driver version. (Closed)

Created:
8 years, 6 months ago by Zhenyao Mo
Modified:
8 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Use nv contrl x extension to query nvidia driver version. This is trying to reland the reverted CL http://codereview.chromium.org/10536232/. I added third_party/libXNVCtrl to content/gpu/DEPS. So we can do it in browser process, not wait until gpu process launches and a gl context is created. This is tested on my linux box with NVIDIA driver. We need to put more code to tell chrome (Linux/NVIDIA) that we have enough information for blacklisting, so at GPU launch time we don't need to collect GPUInfo. Will do it in a followup CL. BUG=122912 TEST=tree green R=jam@chromium.org TBR=kbr,piman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143472

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -10 lines) Patch
M content/content_gpu.gypi View 1 chunk +5 lines, -0 lines 0 comments Download
M content/gpu/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/gpu/gpu_info_collector_linux.cc View 1 5 chunks +52 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Zhenyao Mo
jam: please have a look.
8 years, 6 months ago (2012-06-21 19:08:37 UTC) #1
jam
lgtm http://codereview.chromium.org/10641006/diff/1/content/gpu/gpu_info_collector_linux.cc File content/gpu/gpu_info_collector_linux.cc (right): http://codereview.chromium.org/10641006/diff/1/content/gpu/gpu_info_collector_linux.cc#newcode177 content/gpu/gpu_info_collector_linux.cc:177: return ""; nit: here and below, prefer return ...
8 years, 6 months ago (2012-06-21 21:33:56 UTC) #2
Zhenyao Mo
8 years, 6 months ago (2012-06-21 22:30:51 UTC) #3
https://chromiumcodereview.appspot.com/10641006/diff/1/content/gpu/gpu_info_c...
File content/gpu/gpu_info_collector_linux.cc (right):

https://chromiumcodereview.appspot.com/10641006/diff/1/content/gpu/gpu_info_c...
content/gpu/gpu_info_collector_linux.cc:177: return "";
On 2012/06/21 21:33:57, John Abd-El-Malek wrote:
> nit: here and below, prefer return std::string()

Done.

https://chromiumcodereview.appspot.com/10641006/diff/1/content/gpu/gpu_info_c...
content/gpu/gpu_info_collector_linux.cc:247: fprintf(stderr, "%s\n\n\n",
driver_version.c_str());
On 2012/06/21 21:33:57, John Abd-El-Malek wrote:
> nit: spacing

this line is for local debugging purpose.  removed in the final CL

Powered by Google App Engine
This is Rietveld 408576698