Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1064003: Enable the Core Animation NPAPI drawing mode on 10.6 (except for QuickTime) (Closed)

Created:
10 years, 9 months ago by stuartmorgan
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Enable the Core Animation NPAPI drawing mode on 10.6 (except for QuickTime) Allows plugins other than QuickTime (see http://crbug.com/38336) to negotiate the Core Animation drawing model. Note that for the moment, our wmode hack will prevent Flash from trying to use Core Animation; that will be removed later. BUG=32012 TEST=On 10.6: Unity3D should not use any renderer CPU on most sites, and should now have good performance; QuickTime and Flash10.1 should be unchanged for now. On 10.5: Everything should be unchanged. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42285

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove Flash wmode change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M webkit/glue/plugins/plugin_host.cc View 1 2 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
stuartmorgan
10 years, 9 months ago (2010-03-18 00:04:17 UTC) #1
Avi (use Gerrit)
http://codereview.chromium.org/1064003/diff/1/3 File webkit/glue/plugins/plugin_host.cc (right): http://codereview.chromium.org/1064003/diff/1/3#newcode799 webkit/glue/plugins/plugin_host.cc:799: // negiate that model. negotiate
10 years, 9 months ago (2010-03-18 01:28:42 UTC) #2
pink (ping after 24hrs)
LGTM http://codereview.chromium.org/1064003/diff/1/3 File webkit/glue/plugins/plugin_host.cc (right): http://codereview.chromium.org/1064003/diff/1/3#newcode800 webkit/glue/plugins/plugin_host.cc:800: scoped_refptr<NPAPI::PluginInstance> plugin = FindInstance(id); is this guaranteed to ...
10 years, 9 months ago (2010-03-18 17:00:29 UTC) #3
stuartmorgan
http://codereview.chromium.org/1064003/diff/1/3 File webkit/glue/plugins/plugin_host.cc (right): http://codereview.chromium.org/1064003/diff/1/3#newcode799 webkit/glue/plugins/plugin_host.cc:799: // negiate that model. On 2010/03/18 01:28:42, Avi wrote: ...
10 years, 9 months ago (2010-03-18 18:10:08 UTC) #4
stuartmorgan
10 years, 9 months ago (2010-03-22 19:35:42 UTC) #5
FYI: I've stripped the Flash wmode change out of this to decouple the basic
enabling of Core Animation from fixing any Flash-specific issues (e.g., the
issue we're currently seeing with full-screen Flash). No need for a new review.

Powered by Google App Engine
This is Rietveld 408576698