Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2166)

Unified Diff: chrome/browser/net/chrome_network_delegate.cc

Issue 10640019: Remove the HANDLED_EXTERNALLY status code. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: incorporated feedback Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/chrome_network_delegate.cc
diff --git a/chrome/browser/net/chrome_network_delegate.cc b/chrome/browser/net/chrome_network_delegate.cc
index 5bd65b1d1790ce2e72eda8facafd2e1cfee73bac..723dbea83f1c37a384d8b89238288b7204097d33 100644
--- a/chrome/browser/net/chrome_network_delegate.cc
+++ b/chrome/browser/net/chrome_network_delegate.cc
@@ -259,8 +259,9 @@ void ChromeNetworkDelegate::OnRawBytesRead(const net::URLRequest& request,
void ChromeNetworkDelegate::OnCompleted(net::URLRequest* request,
bool started) {
+ const ResourceRequestInfo* info = ResourceRequestInfo::ForRequest(request);
if (request->status().status() == net::URLRequestStatus::SUCCESS ||
- request->status().status() == net::URLRequestStatus::HANDLED_EXTERNALLY) {
+ (info && info->Ignored())) {
darin (slow to review) 2012/08/29 22:01:37 nit: perhaps it would be worth it to also check fo
mkosiba (inactive) 2012/08/30 15:29:43 We already check for status().status() == CANCELED
bool is_redirect = request->response_headers() &&
net::HttpResponseHeaders::IsRedirectResponseCode(
request->response_headers()->response_code());

Powered by Google App Engine
This is Rietveld 408576698