content/public/browser/resource_controller.h - Issue 10640019: Remove the HANDLED_EXTERNALLY status code.

Side by Side Diff: content/public/browser/resource_controller.h

Issue 10640019: Remove the HANDLED_EXTERNALLY status code. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: revert removing DCHECK from URLRequest::DoCancel Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_PUBLIC_BROWSER_RESOURCE_CONTROLLER_H_	5 #ifndef CONTENT_PUBLIC_BROWSER_RESOURCE_CONTROLLER_H_

6 #define CONTENT_PUBLIC_BROWSER_RESOURCE_CONTROLLER_H_	6 #define CONTENT_PUBLIC_BROWSER_RESOURCE_CONTROLLER_H_

7	7

8 namespace content {	8 namespace content {

9	9

10 // Used to either resume a deferred resource load or cancel a resource load at	10 // Used to either resume a deferred resource load or cancel a resource load at

11 // any time.	11 // any time.

12 class ResourceController {	12 class ResourceController {

13 public:	13 public:

14 virtual void Cancel() = 0;	14 virtual void Cancel() = 0;

	15 virtual void CancelWithError(int error) = 0;
	darin (slow to review) 2012/08/10 18:03:02 It looks like we don't need CancelWithError since It looks like we don't need CancelWithError since nothing calls this function in this CL. mkosiba (inactive) 2012/08/29 15:53:01 Done. Show quoted text On 2012/08/10 18:03:02, darin wrote: > It looks like we don't need CancelWithError since nothing calls this function in > this CL. Done.
	16 virtual void HandledExternally() = 0;
	darin (slow to review) 2012/08/10 18:03:02 This doesn't seem like the best name for this func This doesn't seem like the best name for this function. We want to tell the ResourceLoader to cancel the request _and_ to also forget that the request was ever generated. Maybe CancelAndIgnore or CancelAndSuppressErrorReporting? Neither of these suggestions strike me as all that great. Another idea is to make this into a function that synthesizes a HTTP 204 "No content" response. CancelAndReturnNoContent or CancelAndSynthesizeNoContent or CancelAndSimulateNoContent? I'm having a hard time coming up with a good solution to this problem. CancelAndIgnore is probably my preference at this point. It at least conveys the fact that the URLRequest will be canceled. Using the term "ignore" is consistent with the WebKit API where we have WebNavigationPolicyIgnore, which is roughly equivalent. Plus if you read all of ResourceController methods with a suffix of "Request", this one would be CancelAndIgnore-Request, which is pretty close to my description of "cancel the request and forget that the request was ever generated." I would then use terms like "was_ignored" instead of "was_handled_externally." mkosiba (inactive) 2012/08/29 15:53:01 Ok, will go with CancelAndIgnore. Show quoted text On 2012/08/10 18:03:02, darin wrote: > This doesn't seem like the best name for this function. We want to tell the > ResourceLoader to cancel the request _and_ to also forget that the request was > ever generated. Maybe CancelAndIgnore or CancelAndSuppressErrorReporting? > Neither of these suggestions strike me as all that great. > > Another idea is to make this into a function that synthesizes a HTTP 204 "No > content" response. CancelAndReturnNoContent or CancelAndSynthesizeNoContent or > CancelAndSimulateNoContent? > > I'm having a hard time coming up with a good solution to this problem. > > CancelAndIgnore is probably my preference at this point. It at least conveys > the fact that the URLRequest will be canceled. Using the term "ignore" is > consistent with the WebKit API where we have WebNavigationPolicyIgnore, which is > roughly equivalent. Plus if you read all of ResourceController methods with a > suffix of "Request", this one would be CancelAndIgnore-Request, which is pretty > close to my description of "cancel the request and forget that the request was > ever generated." > > I would then use terms like "was_ignored" instead of "was_handled_externally." Ok, will go with CancelAndIgnore.
15 virtual void Resume() = 0;	17 virtual void Resume() = 0;

16 protected:	18 protected:

17 virtual ~ResourceController() {}	19 virtual ~ResourceController() {}

18 };	20 };

19	21

20 } // namespace content	22 } // namespace content

21	23

22 #endif // CONTENT_PUBLIC_BROWSER_RESOURCE_CONTROLLER_H_	24 #endif // CONTENT_PUBLIC_BROWSER_RESOURCE_CONTROLLER_H_

OLD	NEW

« no previous file with comments | « content/common/resource_messages.h ('k') | content/public/browser/resource_request_info.h » ('j') | net/base/net_errors.h » ('J')