Remove the HANDLED_EXTERNALLY status code.

net/url_request/url_request.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/url_request.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/compiler_specific.h"
@@ skipping 495 matching lines @@
 void URLRequest::CancelWithSSLError(int error, const SSLInfo& ssl_info) {
   // This should only be called on a started request.
   if (!is_pending_ || !job_ || job_->has_response_started()) {
     NOTREACHED();
     return;
   }
   DoCancel(error, ssl_info);
 }
 
 void URLRequest::DoCancel(int error, const SSLInfo& ssl_info) {
-  DCHECK(error < 0);

[darin (slow to review), 2012/07/11 18:12:43]

It feels wrong to allow non-negative (non-error) results here.  If we want to
support cancelling the request with OK_HANDLED_EXTERNALLY, then we should
probably make it a negative value: ERR_HANDLED_EXTERNALLY.

This brings us back to the previous discussion about whether or not this is an
error code or a success code.  We should also think about whether we want the
network stack to know about the concept of "handled externally".

The goal of removing URLRequestStatus::HANDLED_EXTERNALLY is either to remove
the concept of "handled externally" from the network stack or to help us
eliminate URLRequestStatus altogether.  Both seem like reasonable goals.

I am curious about completely eliminating the "handled externally" concept from
the network stack since it isn't something that makes much sense to a network
stack.  A network stack produces data or errors.

"handled externally" is something that only makes sense to web page navigation
requests.

-
   // If the URL request already has an error status, then canceling is a no-op.
   // Plus, we don't want to change the error status once it has been set.
   if (status_.is_success()) {
     status_.set_status(URLRequestStatus::CANCELED);
     status_.set_error(error);
     response_info_.ssl_info = ssl_info;
   }
 
   if (is_pending_ && job_)
     job_->Kill();
@@ skipping 376 matching lines @@
       new base::debug::StackTrace(NULL, 0);
   *stack_trace_copy = stack_trace;
   stack_trace_.reset(stack_trace_copy);
 }
 
 const base::debug::StackTrace* URLRequest::stack_trace() const {
   return stack_trace_.get();
 }
 
 }  // namespace net