Remove the HANDLED_EXTERNALLY status code.

content/browser/renderer_host/async_resource_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/async_resource_handler.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/debug/alias.h"
@@ skipping 270 matching lines @@
     int request_id,
     const net::URLRequestStatus& status,
     const std::string& security_info) {
   // If we crash here, figure out what URL the renderer was requesting.
   // http://crbug.com/107692
   char url_buf[128];
   base::strlcpy(url_buf, request_->url().spec().c_str(), arraysize(url_buf));
   base::debug::Alias(url_buf);
 
   TimeTicks completion_time = TimeTicks::Now();
+
+  int error_code = status.error();
+  if (status.status() == net::URLRequestStatus::IO_PENDING)
+    error_code = net::ERR_IO_PENDING;
+  else if (status.status() == net::URLRequestStatus::CANCELED &&
+           error_code == net::OK)
+    error_code = net::ERR_ABORTED;
+  else if (status.status() == net::URLRequestStatus::FAILED &&
+           error_code == net::OK)
+    error_code = net::ERR_FAILED;

[mkosiba (inactive), 2012/06/26 17:01:42]

I was going back and forth on whether to do this here or to have some similar
DCHECK in URLRequestStatus and fix up callers. Ultimately settled for this
approach as fixing up callers to pass would introduce noise to the CL. We could
do it as a preliminary to this one.

   filter_->Send(new ResourceMsg_RequestComplete(routing_id_,
                                                 request_id,
-                                                status,
+                                                error_code,
                                                 security_info,
                                                 completion_time));
 
   // If we still have a read buffer, then see about caching it for later...
   // Note that we have to make sure the buffer is not still being used, so we
   // have to perform an explicit check on the status code.
   if (g_spare_read_buffer ||
       net::URLRequestStatus::SUCCESS != status.status()) {
     read_buffer_ = NULL;
   } else if (read_buffer_.get()) {
@@ skipping 26 matching lines @@
 }
 
 void AsyncResourceHandler::ResumeIfDeferred() {
   if (did_defer_) {
     did_defer_ = false;
     controller()->Resume();
   }
 }
 
 }  // namespace content