Browser Plugin: Disable context menu on guests

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 1984 matching lines @@
   // response as RunJavaScriptMessage.
   string16 ignored_result;
   SendAndRunNestedMessageLoop(new ViewHostMsg_RunBeforeUnloadConfirm(
       routing_id_, frame->document().url(), message, is_reload,
       &success, &ignored_result));
   return success;
 }
 
 void RenderViewImpl::showContextMenu(
     WebFrame* frame, const WebContextMenuData& data) {
+  // TODO(fsamuel): In the future, we might want the embedder to be able to
+  // decide whether the guest can show a context menu or not.

[jam, 2012/06/22 20:43:05]

nit: put the bug number here

+  if (GetGuestToEmbedderChannel())
+    return;

[Charlie Reis, 2012/06/22 19:55:23]

I'm not 100% sure that the renderer isn't expecting some kind of reply from
this, but I think it's ok.

[Fady Samuel, 2012/06/22 20:03:44]

OK. This seems to work OK. A good fix with an API will take longer but this way
avoids the crash and invalid options like "Open Link in New Window" until we
have an API.

+
   content::ContextMenuParams params(data);
 
   // frame is NULL if invoked by BlockedPlugin.
   if (frame)
     params.frame_id = frame->identifier();
 
   // Serializing a GURL longer than content::kMaxURLChars will fail, so don't do
   // it.  We replace it with an empty GURL so the appropriate items are disabled
   // in the context menu.
   // TODO(jcivelli): http://crbug.com/45160 This prevents us from saving large
@@ skipping 3662 matching lines @@
 bool RenderViewImpl::WebWidgetHandlesCompositorScheduling() const {
   return !!RenderThreadImpl::current()->compositor_thread();
 }
 
 void RenderViewImpl::OnJavaBridgeInit() {
   DCHECK(!java_bridge_dispatcher_);
 #if defined(ENABLE_JAVA_BRIDGE)
   java_bridge_dispatcher_ = new JavaBridgeDispatcher(this);
 #endif
 }