Add a presubmit check to stop any more usages of harmful browser::Find* methods while we work throu…

PRESUBMIT.py

Index: PRESUBMIT.py
===================================================================
--- PRESUBMIT.py	(revision 144105)
+++ PRESUBMIT.py	(working copy)
@@ -125,7 +125,7 @@
        'New code should not use ScopedAllowIO. Post a task to the blocking pool'
        'or the FILE thread instead.',
       ),
-      False,
+      True,

[Avi (use Gerrit), 2012/06/26 18:42:58]

Wow. OK.

[jam, 2012/06/26 19:31:33]

why are you surprised? We don't want any more of these.

     ),
     (
       'FilePathWatcher::Delegate',
@@ -135,6 +135,51 @@
       ),
       False,
     ),
+    (
+      'browser::FindLastActiveWithProfile',
+      (
+       'This function is deprecated and we\'re working on removing it. Pass '
+       'more context to get a Browser*, like a WebContents, window, or session '
+       'id. Talk to ben@ or jam@ for more information.',
+      ),
+      True,
+    ),
+    (
+      'browser::FindBrowserWithProfile',
+      (
+       'This function is deprecated and we\'re working on removing it. Pass '
+       'more context to get a Browser*, like a WebContents, window, or session '
+       'id. Talk to ben@ or jam@ for more information.',
+      ),
+      True,
+    ),
+    (
+      'browser::FindAnyBrowser',
+      (
+       'This function is deprecated and we\'re working on removing it. Pass '
+       'more context to get a Browser*, like a WebContents, window, or session '
+       'id. Talk to ben@ or jam@ for more information.',
+      ),
+      True,
+    ),
+    (
+      'browser::FindOrCreateTabbedBrowser',
+      (
+       'This function is deprecated and we\'re working on removing it. Pass '
+       'more context to get a Browser*, like a WebContents, window, or session '
+       'id. Talk to ben@ or jam@ for more information.',
+      ),
+      True,
+    ),
+    (
+      'browser::FindTabbedBrowser',
+      (
+       'This function is deprecated and we\'re working on removing it. Pass '
+       'more context to get a Browser*, like a WebContents, window, or session '
+       'id. Talk to ben@ or jam@ for more information.',

[Avi (use Gerrit), 2012/06/26 18:42:58]

I think I screwed up in porting to _BANNED_CPP_FUNCTIONS. Each of these strings
should not end in a space, and there should be a comma at the end of each line.
Can you fix yours and the ones I put in there too?

[jam, 2012/06/26 19:31:33]

Done.

+      ),
+      True,
+    ),
 )