Enable base::NonThreadSafe when DCHECK_ALWAYS_ON is set

base/threading/non_thread_safe.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_THREADING_NON_THREAD_SAFE_H_
 #define BASE_THREADING_NON_THREAD_SAFE_H_
 #pragma once
 
-// Classes deriving from NonThreadSafe may need to supress MSVC warning 4275:
+// Classes deriving from NonThreadSafe may need to suppress MSVC warning 4275:
 // non dll-interface class 'Bar' used as base for dll-interface class 'Foo'.
 // There is a specific macro to do it: NON_EXPORTED_BASE(), defined in
 // compiler_specific.h
 #include "base/compiler_specific.h"
 
-#ifndef NDEBUG
+// Apart from debug builds, we also enable the NonThreadSafe checks in
+// builds with DCHECK_ALWAYS_ON so that trybots and waterfall bots
+// with this define will get the same level of thread checking as
+// debug bots.
+//
+// Note that this does not perfectly match situations where DCHECK is
+// enabled.  For example a non-official release build may have
+// DCHECK_ALWAYS_ON undefined (and therefore NonThreadSafe would be
+// disabled) but have DCHECKs enabled at runtime.

[jam, 2012/06/26 01:56:30]

nit: instead of copying the comment, I would just say 
// see comment at top of thread_checker.h

+#if (!defined(NDEBUG) || defined(DCHECK_ALWAYS_ON))
+#define ENABLE_NON_THREAD_SAFE 1
+#else
+#define ENABLE_NON_THREAD_SAFE 0
+#endif
+
+#if ENABLE_NON_THREAD_SAFE
 #include "base/threading/non_thread_safe_impl.h"
 #endif
 
 namespace base {
 
 // Do nothing implementation of NonThreadSafe, for release mode.
 //
 // Note: You should almost always use the NonThreadSafe class to get
 // the right version of the class for your build configuration.
 class NonThreadSafeDoNothing {
@@ skipping 20 matching lines @@
 //     DCHECK(CalledOnValidThread());
 //     ... (do stuff) ...
 //   }
 // }
 //
 // Note that base::ThreadChecker offers identical functionality to
 // NonThreadSafe, but does not require inheritence. In general, it is preferable
 // to have a base::ThreadChecker as a member, rather than inherit from
 // NonThreadSafe. For more details about when to choose one over the other, see
 // the documentation for base::ThreadChecker.
-//
-// In Release mode, CalledOnValidThread will always return true.
-#ifndef NDEBUG
+#if ENABLE_NON_THREAD_SAFE
 class NonThreadSafe : public NonThreadSafeImpl {
 };
 #else
 class NonThreadSafe : public NonThreadSafeDoNothing {
 };
-#endif  // NDEBUG
+#endif  // ENABLE_NON_THREAD_SAFE
+
+#undef ENABLE_NON_THREAD_SAFE
 
 }  // namespace base
 
 #endif  // BASE_NON_THREAD_SAFE_H_