Adding Application Data dialog for isolated apps

chrome/browser/resources/options2/cookies_list.js

Index: chrome/browser/resources/options2/cookies_list.js
diff --git a/chrome/browser/resources/options2/cookies_list.js b/chrome/browser/resources/options2/cookies_list.js
index 8a4ae577c02f4d747b0f37eddc89e8d827ab04ff..f0222da8493287c759d64a3652290adafc1600ea 100644
--- a/chrome/browser/resources/options2/cookies_list.js
+++ b/chrome/browser/resources/options2/cookies_list.js
@@ -118,16 +118,26 @@ cr.define('options', function() {
     /** @inheritDoc */
     decorate: function() {
       this.siteChild = this.ownerDocument.createElement('div');
-      this.siteChild.className = 'cookie-site';
       this.dataChild = this.ownerDocument.createElement('div');
-      this.dataChild.className = 'cookie-data';
       this.sizeChild = this.ownerDocument.createElement('div');
-      this.sizeChild.className = 'cookie-size';
       this.itemsChild = this.ownerDocument.createElement('div');
-      this.itemsChild.className = 'cookie-items';
       this.infoChild = this.ownerDocument.createElement('div');
-      this.infoChild.className = 'cookie-details';
       this.infoChild.hidden = true;
+
+      if (this.origin.data.appId && this.origin.data.appId !== '') {

[Evan Stade, 2012/06/27 04:53:00]

'' is falsey so the second half of this check is not necessary.

[nasko, 2012/06/27 17:17:01]

The second half is supposed to check if the appId is an empty string or not. I
can see in the debugger that it does evaluate differently, so the proper class
is set on the object.

[Evan Stade, 2012/06/28 04:15:13]

for which value of this.origin.data.appId does [1] behave differently than [2]

[1] if (this.origin.data.appId && this.origin.data.appId !== '')
[2] if (this.origin.data.appId)

[nasko, 2012/06/29 00:46:52]

Done.

+        this.siteChild.className = 'app-cookie-site';
+        this.dataChild.className = 'app-cookie-data';
+        this.sizeChild.className = 'app-cookie-size';
+        this.itemsChild.className = 'app-cookie-items';
+        this.infoChild.className = 'app-cookie-details';
+      } else {
+        this.siteChild.className = 'cookie-site';
+        this.dataChild.className = 'cookie-data';
+        this.sizeChild.className = 'cookie-size';
+        this.itemsChild.className = 'cookie-items';
+        this.infoChild.className = 'cookie-details';
+      }
+
       var remove = this.ownerDocument.createElement('button');
       remove.textContent = loadTimeData.getString('remove_cookie');
       remove.onclick = this.removeCookie_.bind(this);