Adding Application Data dialog for isolated apps

chrome/browser/ui/webui/options2/cookies_view_handler2.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options2/cookies_view_handler2.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
+#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/extension_set.h"
 #include "chrome/browser/browsing_data_appcache_helper.h"
 #include "chrome/browser/browsing_data_cookie_helper.h"
 #include "chrome/browser/browsing_data_database_helper.h"
 #include "chrome/browser/browsing_data_file_system_helper.h"
 #include "chrome/browser/browsing_data_indexed_db_helper.h"
 #include "chrome/browser/browsing_data_local_storage_helper.h"
 #include "chrome/browser/browsing_data_quota_helper.h"
 #include "chrome/browser/browsing_data_server_bound_cert_helper.h"
+#include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/webui/cookies_tree_model_util.h"
 #include "content/public/browser/web_ui.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace options2 {
 
 CookiesViewHandler::CookiesViewHandler()
-    : batch_update_(false),
-      model_util_(new CookiesTreeModelUtil) {
+  : batch_update_(false),
+    app_context_(false),
+    model_util_(new CookiesTreeModelUtil) {
 }
 
 CookiesViewHandler::~CookiesViewHandler() {
 }
 
 void CookiesViewHandler::GetLocalizedValues(
     DictionaryValue* localized_strings) {
   DCHECK(localized_strings);
 
   static OptionsStringResource resources[] = {
@@ skipping 43 matching lines @@
       IDS_COOKIES_SERVER_BOUND_CERT_TYPE_LABEL },
     { "label_server_bound_cert_created",
       IDS_COOKIES_SERVER_BOUND_CERT_CREATED_LABEL },
     { "label_server_bound_cert_expires",
       IDS_COOKIES_SERVER_BOUND_CERT_EXPIRES_LABEL },
   };
 
   RegisterStrings(localized_strings, resources, arraysize(resources));
   RegisterTitle(localized_strings, "cookiesViewPage",
                 IDS_COOKIES_WEBSITE_PERMISSIONS_WINDOW_TITLE);
+  RegisterTitle(localized_strings, "appCookiesViewPage",
+                IDS_APP_COOKIES_WEBSITE_PERMISSIONS_WINDOW_TITLE);
 }
 
 void CookiesViewHandler::RegisterMessages() {
   web_ui()->RegisterMessageCallback("updateCookieSearchResults",
       base::Bind(&CookiesViewHandler::UpdateSearchResults,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback("removeAllCookies",
       base::Bind(&CookiesViewHandler::RemoveAll,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback("removeCookie",
       base::Bind(&CookiesViewHandler::Remove,
                  base::Unretained(this)));
   web_ui()->RegisterMessageCallback("loadCookie",
       base::Bind(&CookiesViewHandler::LoadChildren,
                  base::Unretained(this)));
+  web_ui()->RegisterMessageCallback("setViewContext",
+      base::Bind(&CookiesViewHandler::SetViewContext,
+                 base::Unretained(this)));
 }
 
 void CookiesViewHandler::TreeNodesAdded(ui::TreeModel* model,
                                         ui::TreeModelNode* parent,
                                         int start,
                                         int count) {
   // Skip if there is a batch update in progress.
   if (batch_update_)
     return;
 
-  CookieTreeNode* parent_node = cookies_tree_model_->AsNode(parent);
+  CookiesTreeModel* tree_model = static_cast<CookiesTreeModel*>(model);
+  CookieTreeNode* parent_node = tree_model->AsNode(parent);
 
   ListValue* children = new ListValue;
   model_util_->GetChildNodeList(parent_node, start, count,
                                             children);
 
   ListValue args;
-  args.Append(parent == cookies_tree_model_->GetRoot() ?
+  args.Append(parent == tree_model->GetRoot() ?
       Value::CreateNullValue() :
       Value::CreateStringValue(
           model_util_->GetTreeNodeId(parent_node)));
   args.Append(Value::CreateIntegerValue(start));
   args.Append(children);
-  web_ui()->CallJavascriptFunction("CookiesView.onTreeItemAdded", args);
+  web_ui()->CallJavascriptFunction(
+      GetCallback("onTreeItemAdded", GetTreeModel()), args);
 }
 
 void CookiesViewHandler::TreeNodesRemoved(ui::TreeModel* model,
                                           ui::TreeModelNode* parent,
                                           int start,
                                           int count) {
   // Skip if there is a batch update in progress.
   if (batch_update_)
     return;
 
+  CookiesTreeModel* tree_model = static_cast<CookiesTreeModel*>(model);
+
   ListValue args;
-  args.Append(parent == cookies_tree_model_->GetRoot() ?
+  args.Append(parent == tree_model->GetRoot() ?
       Value::CreateNullValue() :
       Value::CreateStringValue(model_util_->GetTreeNodeId(
-          cookies_tree_model_->AsNode(parent))));
+          tree_model->AsNode(parent))));
   args.Append(Value::CreateIntegerValue(start));
   args.Append(Value::CreateIntegerValue(count));
-  web_ui()->CallJavascriptFunction("CookiesView.onTreeItemRemoved", args);
+  web_ui()->CallJavascriptFunction(
+      GetCallback("onTreeItemRemoved", GetTreeModel()), args);
 }
 
 void CookiesViewHandler::TreeModelBeginBatch(CookiesTreeModel* model) {
   DCHECK(!batch_update_);  // There should be no nested batch begin.
   batch_update_ = true;
 }
 
 void CookiesViewHandler::TreeModelEndBatch(CookiesTreeModel* model) {
   DCHECK(batch_update_);
   batch_update_ = false;
 
-  SendChildren(cookies_tree_model_->GetRoot());
+  SendChildren(model->GetRoot());
 }
 
 void CookiesViewHandler::EnsureCookiesTreeModelCreated() {

[Bernhard Bauer, 2012/07/10 18:18:03]

Hmm, it looks like exactly one of |app_cookies_tree_model_| and
|cookies_tree_model_| is non-NULL, right? If so, it would make sense to merge
the two fields. Then, we could merge the two if-statements here, which have a
lot of common code.

[nasko, 2012/07/10 19:54:10]

There is one CookiesViewHandler for the lifetime of the Settings page, so both
pointers can be non-NULL.

-  if (!cookies_tree_model_.get()) {
+  if (!app_context_ && !cookies_tree_model_.get()) {
     Profile* profile = Profile::FromWebUI(web_ui());
-    cookies_tree_model_.reset(new CookiesTreeModel(
+    ContainerMap apps_map;
+    apps_map[std::string()] = new LocalDataContainer(
+        "Site Data", std::string(),
         new BrowsingDataCookieHelper(profile->GetRequestContext()),
         new BrowsingDataDatabaseHelper(profile),
         new BrowsingDataLocalStorageHelper(profile),
         NULL,
         new BrowsingDataAppCacheHelper(profile),
         BrowsingDataIndexedDBHelper::Create(profile),
         BrowsingDataFileSystemHelper::Create(profile),
         BrowsingDataQuotaHelper::Create(profile),
-        BrowsingDataServerBoundCertHelper::Create(profile),
-        false));
+        BrowsingDataServerBoundCertHelper::Create(profile));
+    cookies_tree_model_.reset(new CookiesTreeModel(apps_map, false));
     cookies_tree_model_->AddCookiesTreeObserver(this);
   }
+
+  if (app_context_ && !app_cookies_tree_model_.get()) {
+    Profile* profile = Profile::FromWebUI(web_ui());
+    ContainerMap apps_map;
+    const ExtensionService* service = profile->GetExtensionService();
+    if (service) {
+      const ExtensionSet* extensions = service->extensions();
+      for (ExtensionSet::const_iterator it = extensions->begin();
+           it != extensions->end(); ++it) {
+        if ((*it)->is_storage_isolated()) {
+          net::URLRequestContextGetter* context_getter =
+              profile->GetRequestContextForIsolatedApp((*it)->id());
+          // TODO(nasko): When new types of storage are isolated, add the
+          // appropriate browsing data helper objects to the consutrctor.

[Bernhard Bauer, 2012/07/10 18:18:03]

Nit: constructor

[nasko, 2012/07/10 19:54:10]

Done.

+          // For now, just cookies are isolated, so other parameters are NULL.
+          apps_map[(*it)->id()] = new LocalDataContainer(
+              (*it)->name(), (*it)->id(),
+              new BrowsingDataCookieHelper(context_getter),
+              NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL);
+        }
+      }
+      app_cookies_tree_model_.reset(new CookiesTreeModel(apps_map, false));
+      app_cookies_tree_model_->AddCookiesTreeObserver(this);
+    }
+  }
 }
 
 void CookiesViewHandler::UpdateSearchResults(const ListValue* args) {
-  std::string query;
+  string16 query;
   if (!args->GetString(0, &query)) {
     return;
   }
 
   EnsureCookiesTreeModelCreated();
 
-  cookies_tree_model_->UpdateSearchResults(UTF8ToWide(query));
+  GetTreeModel()->UpdateSearchResults(query);
 }
 
 void CookiesViewHandler::RemoveAll(const ListValue* args) {
   EnsureCookiesTreeModelCreated();
-  cookies_tree_model_->DeleteAllStoredObjects();
+  GetTreeModel()->DeleteAllStoredObjects();
 }
 
 void CookiesViewHandler::Remove(const ListValue* args) {
   std::string node_path;
   if (!args->GetString(0, &node_path)) {
     return;
   }
 
   EnsureCookiesTreeModelCreated();
 
   const CookieTreeNode* node = model_util_->GetTreeNodeFromPath(
-      cookies_tree_model_->GetRoot(), node_path);
+      GetTreeModel()->GetRoot(), node_path);
   if (node)
-    cookies_tree_model_->DeleteCookieNode(const_cast<CookieTreeNode*>(node));
+    GetTreeModel()->DeleteCookieNode(const_cast<CookieTreeNode*>(node));
 }
 
 void CookiesViewHandler::LoadChildren(const ListValue* args) {
   std::string node_path;
   if (!args->GetString(0, &node_path)) {
     return;
   }
 
   EnsureCookiesTreeModelCreated();
 
   const CookieTreeNode* node = model_util_->GetTreeNodeFromPath(
-      cookies_tree_model_->GetRoot(), node_path);
+      GetTreeModel()->GetRoot(), node_path);
   if (node)
     SendChildren(node);
 }
 
 void CookiesViewHandler::SendChildren(const CookieTreeNode* parent) {
   ListValue* children = new ListValue;
   model_util_->GetChildNodeList(parent, 0, parent->child_count(),
       children);
 
   ListValue args;
-  args.Append(parent == cookies_tree_model_->GetRoot() ?
+  args.Append(parent == GetTreeModel()->GetRoot() ?
       Value::CreateNullValue() :
       Value::CreateStringValue(model_util_->GetTreeNodeId(parent)));
   args.Append(children);
 
-  web_ui()->CallJavascriptFunction("CookiesView.loadChildren", args);
+  web_ui()->CallJavascriptFunction(
+      GetCallback("loadChildren", GetTreeModel()), args);
+}
+
+void CookiesViewHandler::SetViewContext(const base::ListValue* args) {
+  bool app_context = false;
+  if (args->GetBoolean(0, &app_context))
+    app_context_ = app_context;
+}
+
+CookiesTreeModel* CookiesViewHandler::GetTreeModel() {
+  CookiesTreeModel* model = app_context_ ?
+      app_cookies_tree_model_.get() : cookies_tree_model_.get();
+  DCHECK(model);
+  return model;
+}
+
+std::string CookiesViewHandler::GetCallback(
+     std::string method, CookiesTreeModel* model) {

[Bernhard Bauer, 2012/07/10 18:18:03]

You're always calling this method with GetTreeModel(), which looks at
|app_context_| in turn, so you could just leave out the parameter, and directly
look at |app_context_|.

[nasko, 2012/07/10 19:54:10]

This should be acting on the model. I've changed the TreeNodesAdded/Removed to
pass the model parameter, not the GetTreeModel() one, as it was pointed in
earlier review by Evan.

+  std::string callback("CookiesView");
+
+  if (model == app_cookies_tree_model_) {

[Bernhard Bauer, 2012/07/10 18:18:03]

Nit: braces are unnecessary.

[nasko, 2012/07/10 19:54:10]

Done.

+    callback.append("App");
+  }
+  return callback.append(".").append(method);
 }
 
 }  // namespace options2