Adding Application Data dialog for isolated apps

chrome/browser/resources/options2/cookies_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /** @const */ var DeletableItemList = options.DeletableItemList;
   /** @const */ var DeletableItem = options.DeletableItem;
   /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
   /** @const */ var ListSingleSelectionModel = cr.ui.ListSingleSelectionModel;
 
@@ skipping 100 matching lines @@
 
     return listItem;
   }
 
   CookieListItem.prototype = {
     __proto__: DeletableItem.prototype,
 
     /** @inheritDoc */
     decorate: function() {
       this.siteChild = this.ownerDocument.createElement('div');
-      this.siteChild.className = 'cookie-site';
       this.dataChild = this.ownerDocument.createElement('div');
-      this.dataChild.className = 'cookie-data';
       this.sizeChild = this.ownerDocument.createElement('div');
-      this.sizeChild.className = 'cookie-size';
       this.itemsChild = this.ownerDocument.createElement('div');
-      this.itemsChild.className = 'cookie-items';
       this.infoChild = this.ownerDocument.createElement('div');
-      this.infoChild.className = 'cookie-details';
       this.infoChild.hidden = true;
+
+      if (this.origin.data.appId && this.origin.data.appId !== '') {

[Evan Stade, 2012/06/27 04:53:00]

'' is falsey so the second half of this check is not necessary.

[nasko, 2012/06/27 17:17:01]

The second half is supposed to check if the appId is an empty string or not. I
can see in the debugger that it does evaluate differently, so the proper class
is set on the object.

[Evan Stade, 2012/06/28 04:15:13]

for which value of this.origin.data.appId does [1] behave differently than [2]

[1] if (this.origin.data.appId && this.origin.data.appId !== '')
[2] if (this.origin.data.appId)

[nasko, 2012/06/29 00:46:52]

Done.

+        this.siteChild.className = 'app-cookie-site';
+        this.dataChild.className = 'app-cookie-data';
+        this.sizeChild.className = 'app-cookie-size';
+        this.itemsChild.className = 'app-cookie-items';
+        this.infoChild.className = 'app-cookie-details';
+      } else {
+        this.siteChild.className = 'cookie-site';
+        this.dataChild.className = 'cookie-data';
+        this.sizeChild.className = 'cookie-size';
+        this.itemsChild.className = 'cookie-items';
+        this.infoChild.className = 'cookie-details';
+      }
+
       var remove = this.ownerDocument.createElement('button');
       remove.textContent = loadTimeData.getString('remove_cookie');
       remove.onclick = this.removeCookie_.bind(this);
       this.infoChild.appendChild(remove);
       var content = this.contentElement;
       content.appendChild(this.siteChild);
       content.appendChild(this.dataChild);
       content.appendChild(this.sizeChild);
       content.appendChild(this.itemsChild);
       this.itemsChild.appendChild(this.infoChild);
@@ skipping 713 matching lines @@
       parent.clear();
       this.addByParent_(parent, 0, children);
       parent.endBatchUpdates();
     },
   };
 
   return {
     CookiesList: CookiesList
   };
 });