chrome/browser/extensions/unpacked_installer.cc - Issue 10630021: Modify experimental identity flow to display scope descriptions and details.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/unpacked_installer.cc

Issue 10630021: Modify experimental identity flow to display scope descriptions and details. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/identity/identity_api.cc ('K') | « chrome/browser/extensions/permissions_updater.cc ('k') | chrome/browser/extensions/webstore_installer.h » ('j') | chrome/browser/ui/gtk/extensions/extension_install_dialog_gtk.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/unpacked_installer.cc

diff --git a/chrome/browser/extensions/unpacked_installer.cc b/chrome/browser/extensions/unpacked_installer.cc

index e9c04b77e2b60a37f0a5777eeb4a294e16bb36f4..d256351599684d5691849daf9e96b5bd1b56af06 100644

--- a/chrome/browser/extensions/unpacked_installer.cc

+++ b/chrome/browser/extensions/unpacked_installer.cc

@@ -64,7 +64,7 @@ void SimpleExtensionLoadPrompt::ShowPrompt() {

void SimpleExtensionLoadPrompt::InstallUIProceed() {

if (service_weak_.get()) {

extensions::PermissionsUpdater perms_updater(service_weak_->profile());

- perms_updater.GrantActivePermissions(extension_);

+ perms_updater.GrantActivePermissions(extension_, false);

service_weak_->OnExtensionInstalled(

extension_, false, StringOrdinal()); // Not from web store.

}

@@ -237,7 +237,7 @@ void UnpackedInstaller::OnLoaded(

}

PermissionsUpdater perms_updater(service_weak_->profile());

- perms_updater.GrantActivePermissions(extension);

+ perms_updater.GrantActivePermissions(extension, false);

service_weak_->OnExtensionInstalled(extension,

false, // Not from web store.

StringOrdinal());