Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: lib/compiler/implementation/apiimpl.dart

Issue 10629002: Avoid passing a null uri to translateUri. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/apiimpl.dart
diff --git a/lib/compiler/implementation/apiimpl.dart b/lib/compiler/implementation/apiimpl.dart
index 2296e262de0376aa22e3806ea4f0cdbbf117dc60..fc849c19da8a64b200dbb428009af2b80a4e89e6 100644
--- a/lib/compiler/implementation/apiimpl.dart
+++ b/lib/compiler/implementation/apiimpl.dart
@@ -96,7 +96,7 @@ class Compiler extends leg.Compiler {
}
void reportDiagnostic(leg.SourceSpan span, String message, bool fatal) {
- if (span === null) {
+ if (span === null || span.uri === null) {
ahe 2012/06/22 08:49:33 I would rather avoid creating source spans with ur
Johnni Winther 2012/06/22 11:40:55 Done.
handler(null, null, null, message, fatal);
} else {
handler(translateUri(span.uri, null), span.begin, span.end,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698