Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 10628020: webkit/ppapi: Notify the container when a plugin is accepting touch events. (Closed)

Created:
8 years, 6 months ago by sadrul
Modified:
8 years, 6 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

webkit/ppapi: Notify the container when a plugin is accepting touch events. BUG=128236 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143871

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 1 2 5 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sadrul
The corresponding webkit patch is https://bugs.webkit.org/show_bug.cgi?id=89769
8 years, 6 months ago (2012-06-22 17:50:18 UTC) #1
brettw
http://codereview.chromium.org/10628020/diff/5/webkit/plugins/ppapi/ppapi_webplugin_impl.cc File webkit/plugins/ppapi/ppapi_webplugin_impl.cc (right): http://codereview.chromium.org/10628020/diff/5/webkit/plugins/ppapi/ppapi_webplugin_impl.cc#newcode111 webkit/plugins/ppapi/ppapi_webplugin_impl.cc:111: container_->setAcceptingTouchEvents(instance_->IsAcceptingTouchEvents()); Should the instance do this in Initialize() instead? ...
8 years, 6 months ago (2012-06-22 18:03:53 UTC) #2
sadrul
http://codereview.chromium.org/10628020/diff/5/webkit/plugins/ppapi/ppapi_webplugin_impl.cc File webkit/plugins/ppapi/ppapi_webplugin_impl.cc (right): http://codereview.chromium.org/10628020/diff/5/webkit/plugins/ppapi/ppapi_webplugin_impl.cc#newcode111 webkit/plugins/ppapi/ppapi_webplugin_impl.cc:111: container_->setAcceptingTouchEvents(instance_->IsAcceptingTouchEvents()); On 2012/06/22 18:03:54, brettw wrote: > Should the ...
8 years, 6 months ago (2012-06-22 21:37:09 UTC) #3
brettw
8 years, 6 months ago (2012-06-22 22:35:55 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698