Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 10625: Fix the exception order by remember JS handler in an external handler. (Closed)

Created:
12 years, 1 month ago by Feng Qian
Modified:
9 years, 7 months ago
Reviewers:
iposva
CC:
v8-dev
Visibility:
Public.

Description

Fix the exception order by remember JS handler in an external handler. Committed: http://code.google.com/p/v8/source/detail?r=744

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -7 lines) Patch
M include/v8.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/api.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/top.cc View 1 4 chunks +30 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Feng Qian
12 years, 1 month ago (2008-11-12 01:04:53 UTC) #1
iposva
http://codereview.chromium.org/10625/diff/1/2 File src/top.cc (right): http://codereview.chromium.org/10625/diff/1/2#newcode736 Line 736: // handler. Needs better explanation as discussed.
12 years, 1 month ago (2008-11-12 21:30:14 UTC) #2
iposva
LGTM -Ivan
12 years, 1 month ago (2008-11-12 23:21:26 UTC) #3
Feng Qian
12 years, 1 month ago (2008-11-12 23:21:47 UTC) #4
http://codereview.chromium.org/10625/diff/1/2
File src/top.cc (right):

http://codereview.chromium.org/10625/diff/1/2#newcode736
Line 736: // handler.
On 2008/11/12 21:30:14, iposva wrote:
> Needs better explanation as discussed.

Done.

Powered by Google App Engine
This is Rietveld 408576698