Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: src/codegen-arm.cc

Issue 10624: Enable IC stubs for KeyedLaod/Store on ARM.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ic-arm.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3229 matching lines...) Expand 10 before | Expand all | Expand 10 after
3240 } 3240 }
3241 frame->Push(r0); 3241 frame->Push(r0);
3242 break; 3242 break;
3243 } 3243 }
3244 3244
3245 case KEYED: { 3245 case KEYED: {
3246 // TODO(1241834): Make sure that this it is safe to ignore the 3246 // TODO(1241834): Make sure that this it is safe to ignore the
3247 // distinction between expressions in a typeof and not in a typeof. 3247 // distinction between expressions in a typeof and not in a typeof.
3248 Comment cmnt(masm, "[ Load from keyed Property"); 3248 Comment cmnt(masm, "[ Load from keyed Property");
3249 ASSERT(property != NULL); 3249 ASSERT(property != NULL);
3250 // TODO(1224671): Implement inline caching for keyed loads as on ia32. 3250 Handle<Code> ic(Builtins::builtin(Builtins::KeyedLoadIC_Initialize));
3251 GetPropertyStub stub; 3251
3252 __ CallStub(&stub); 3252 Variable* var = expression_->AsVariableProxy()->AsVariable();
3253 if (var != NULL) {
3254 ASSERT(var->is_global());
3255 __ Call(ic, RelocInfo::CODE_TARGET_CONTEXT);
3256 } else {
3257 __ Call(ic, RelocInfo::CODE_TARGET);
3258 }
3253 frame->Push(r0); 3259 frame->Push(r0);
3254 break; 3260 break;
3255 } 3261 }
3256 3262
3257 default: 3263 default:
3258 UNREACHABLE(); 3264 UNREACHABLE();
3259 } 3265 }
3260 } 3266 }
3261 3267
3262 3268
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
3364 __ Call(ic, RelocInfo::CODE_TARGET); 3370 __ Call(ic, RelocInfo::CODE_TARGET);
3365 frame->Push(r0); 3371 frame->Push(r0);
3366 break; 3372 break;
3367 } 3373 }
3368 3374
3369 case KEYED: { 3375 case KEYED: {
3370 Comment cmnt(masm, "[ Store to keyed Property"); 3376 Comment cmnt(masm, "[ Store to keyed Property");
3371 Property* property = expression_->AsProperty(); 3377 Property* property = expression_->AsProperty();
3372 ASSERT(property != NULL); 3378 ASSERT(property != NULL);
3373 __ RecordPosition(property->position()); 3379 __ RecordPosition(property->position());
3380
3381 // Call IC code.
3382 Handle<Code> ic(Builtins::builtin(Builtins::KeyedStoreIC_Initialize));
3383 // TODO(1222589): Make the IC grab the values from the stack.
3374 frame->Pop(r0); // value 3384 frame->Pop(r0); // value
3375 SetPropertyStub stub; 3385 __ Call(ic, RelocInfo::CODE_TARGET);
3376 __ CallStub(&stub);
3377 frame->Push(r0); 3386 frame->Push(r0);
3378 break; 3387 break;
3379 } 3388 }
3380 3389
3381 default: 3390 default:
3382 UNREACHABLE(); 3391 UNREACHABLE();
3383 } 3392 }
3384 } 3393 }
3385 3394
3386 3395
(...skipping 899 matching lines...) Expand 10 before | Expand all | Expand 10 after
4286 __ mov(r2, Operand(0)); 4295 __ mov(r2, Operand(0));
4287 __ GetBuiltinEntry(r3, Builtins::CALL_NON_FUNCTION); 4296 __ GetBuiltinEntry(r3, Builtins::CALL_NON_FUNCTION);
4288 __ Jump(Handle<Code>(Builtins::builtin(Builtins::ArgumentsAdaptorTrampoline)), 4297 __ Jump(Handle<Code>(Builtins::builtin(Builtins::ArgumentsAdaptorTrampoline)),
4289 RelocInfo::CODE_TARGET); 4298 RelocInfo::CODE_TARGET);
4290 } 4299 }
4291 4300
4292 4301
4293 #undef __ 4302 #undef __
4294 4303
4295 } } // namespace v8::internal 4304 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/ic-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698