Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 10624: Enable IC stubs for KeyedLaod/Store on ARM.... (Closed)

Created:
12 years, 1 month ago by Feng Qian
Modified:
9 years, 7 months ago
Reviewers:
iposva
CC:
v8-dev
Visibility:
Public.

Description

Enable IC stubs for KeyedLaod/Store on ARM. Several functions are not complete yet, always fall back to slow case. It fixes test-api/AccessControlIC test. Committed: http://code.google.com/p/v8/source/detail?r=745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -113 lines) Patch
M src/codegen-arm.cc View 2 chunks +14 lines, -5 lines 0 comments Download
M src/ic-arm.cc View 4 chunks +61 lines, -24 lines 0 comments Download
M src/stub-cache-arm.cc View 8 chunks +276 lines, -84 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Feng Qian
12 years, 1 month ago (2008-11-12 01:02:56 UTC) #1
iposva
12 years, 1 month ago (2008-11-12 21:47:02 UTC) #2
LGTM

A lot of cleanup in here. I like it!

-Ivan

Powered by Google App Engine
This is Rietveld 408576698