Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 10617004: chromeos: Remove "error_libcros_missing" error from file browser private API (Closed)

Created:
8 years, 6 months ago by hashimoto
Modified:
8 years, 6 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Remove "error_libcros_missing" error from file browser private API We don't need this since we are not using Libcros nor this string now. BUG=127051 TEST=git try -b linux_chromeos Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=143888

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 1 chunk +0 lines, -4 lines 1 comment Download
M chrome/browser/resources/file_manager/js/volume_manager.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/file_browser_private.json View 1 chunk +2 lines, -3 lines 0 comments Download
M chromeos/dbus/cros_disks_client.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hashimoto
serya: please review chrome/browser/resources/file_maanger asargent: please review chrome/common/extensions/api satorux: please review chromeos/dbus
8 years, 6 months ago (2012-06-21 06:44:16 UTC) #1
satorux1
LGTM http://codereview.chromium.org/10617004/diff/1/chrome/browser/chromeos/extensions/file_browser_event_router.cc File chrome/browser/chromeos/extensions/file_browser_event_router.cc (left): http://codereview.chromium.org/10617004/diff/1/chrome/browser/chromeos/extensions/file_browser_event_router.cc#oldcode82 chrome/browser/chromeos/extensions/file_browser_event_router.cc:82: return "error_libcros_missing"; Yeah, it should be safe to ...
8 years, 6 months ago (2012-06-21 14:42:23 UTC) #2
asargent_no_longer_on_chrome
chrome/common/extensions/api/file_browser_private.json LGTM
8 years, 6 months ago (2012-06-21 19:16:37 UTC) #3
hashimoto
Serya, could you review chrome/browser/resources/file_manager/js/volume_manager.js?
8 years, 6 months ago (2012-06-22 03:21:26 UTC) #4
hashimoto
kaznacheev, could you review this one line change for chrome/browser/resources/file_manager/js/volume_manager.js as an owner?
8 years, 6 months ago (2012-06-25 02:57:58 UTC) #5
Vladislav Kaznacheev
lgtm
8 years, 6 months ago (2012-06-25 07:40:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10617004/1
8 years, 6 months ago (2012-06-25 07:41:48 UTC) #7
commit-bot: I haz the power
8 years, 6 months ago (2012-06-25 10:08:50 UTC) #8
Change committed as 143888

Powered by Google App Engine
This is Rietveld 408576698