Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2551)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/history/history_tab_helper.cc

Issue 10605003: Fixing some more instances where I put in HistoryServiceFactory::GetForProfile which will force cre… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/history/android/android_history_provider_service.cc ('K') | « chrome/browser/history/android/android_history_provider_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_tab_helper.cc
===================================================================
--- chrome/browser/history/history_tab_helper.cc (revision 143165)
+++ chrome/browser/history/history_tab_helper.cc (working copy)
@@ -182,8 +182,8 @@
if (profile->IsOffTheRecord())
return;
- HistoryService* hs =
- HistoryServiceFactory::GetForProfile(profile, Profile::IMPLICIT_ACCESS);
+ HistoryService* hs = HistoryServiceFactory::GetForProfileIfExists(
+ profile, Profile::IMPLICIT_ACCESS);
if (hs) {
NavigationEntry* entry = tab->GetController().GetLastCommittedEntry();
if (entry) {
« chrome/browser/history/android/android_history_provider_service.cc ('K') | « chrome/browser/history/android/android_history_provider_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698