Wired support for file truncating with RemoteFileSystemOperation::OpenFile() method (case when base…

chrome/browser/chromeos/extensions/file_browser_handler_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_browser_handler_api.h"
 
 #include "base/bind.h"
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/message_loop_proxy.h"
@@ skipping 215 matching lines @@
   file_selector->SelectFile(suggested_name.BaseName(), GetCurrentBrowser());
   return true;
 }
 
 void FileHandlerSelectFileFunction::CreateFileOnFileThread(
     bool success,
     const std::string& file_system_name,
     const GURL& file_system_root) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
 
-  if (success)
-    success = DoCreateFile();

[kinaba, 2012/06/28 05:52:34]

(Not sure if this part is intended to be a part of the landing CL, but just in
case.)

Can we remove this file creation safely?
I can imagine this would cause trouble for GData file system, but just removing
it looks to violate the documented behavior:
http://code.google.com/chrome/extensions/dev/fileBrowserHandler.html.

[zel, 2012/06/28 17:50:46]

Yes, we have to remove this since file picker API will currently create a file
not just grant permissions to it. 

[kinaba, 2012/06/29 01:48:08]

I see, but it changes the behavior of existing code for local filesystem,
it is documented to create a file, not just giving permissions.
We may want to change the spec of the API, or at least leave some comment here.
(It's odd that CreateFileOnFileThread is not creating a file).

   content::BrowserThread::PostTask(content::BrowserThread::UI, FROM_HERE,
       base::Bind(&FileHandlerSelectFileFunction::OnFileCreated, this,
           success, file_system_name, file_system_root));
 }
 
-bool FileHandlerSelectFileFunction::DoCreateFile() {
-  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE));
-
-  // Don't allow links.
-  if (file_util::PathExists(full_path_) && file_util::IsLink(full_path_))
-    return false;
-
-  bool created = false;
-  base::PlatformFileError error = base::PLATFORM_FILE_OK;
-  int creation_flags = base::PLATFORM_FILE_CREATE_ALWAYS |
-                       base::PLATFORM_FILE_READ |
-                       base::PLATFORM_FILE_WRITE;
-  base::CreatePlatformFile(full_path_, creation_flags, &created, &error);
-  return error == base::PLATFORM_FILE_OK;
-}
-
 void FileHandlerSelectFileFunction::OnFileCreated(
     bool success,
     const std::string& file_system_name,
     const GURL& file_system_root) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
 
   FilePath virtual_path;
   if (success)
     virtual_path = GrantPermissions();
   Respond(success, file_system_name, file_system_root, virtual_path);
@@ skipping 46 matching lines @@
     result->set_function_for_test(this);
     return result;
   }
   return new FileSelectorImpl(this);
 }
 
 FileSelector* FileHandlerSelectFileFunction::file_selector_for_test_ = NULL;
 
 bool FileHandlerSelectFileFunction::gesture_check_disabled_for_test_ = false;