Support partitioning of storage contexts based on render_id.

content/browser/web_contents/navigation_controller_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/navigation_controller_impl.h"
 
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/string_number_conversions.h"  // Temporary
 #include "base/string_util.h"
@@ skipping 173 matching lines @@
       last_committed_entry_index_(-1),
       pending_entry_index_(-1),
       transient_entry_index_(-1),
       web_contents_(web_contents),
       max_restored_page_id_(-1),
       ALLOW_THIS_IN_INITIALIZER_LIST(ssl_manager_(this)),
       needs_reload_(false),
       session_storage_namespace_(session_storage_namespace),
       pending_reload_(NO_RELOAD) {
   DCHECK(browser_context_);
   if (!session_storage_namespace_) {

[Charlie Reis, 2012/07/02 23:21:23]

Did you decide that having this on the NavigationController is ok, even though
we can navigate from one namespace to another?

[awong, 2012/07/09 20:37:43]

No...this isn't okay.  But I'm going to fix it in another CL. This one has been
pending too long.

     session_storage_namespace_ = new SessionStorageNamespaceImpl(
         static_cast<DOMStorageContextImpl*>(
-            BrowserContext::GetDOMStorageContext(browser_context_)));
+            BrowserContext::GetDefaultDOMStorageContext(browser_context)));

[nasko, 2012/06/29 23:08:56]

Any particular reason you moved from browser_context_ to browser_context?

[awong, 2012/07/09 20:37:43]

nope. Moved back.

   }
 }
 
 NavigationControllerImpl::~NavigationControllerImpl() {
   DiscardNonCommittedEntriesInternal();
 }
 
 WebContents* NavigationControllerImpl::GetWebContents() const {
   return web_contents_;
 }
@@ skipping 1246 matching lines @@
   for (int i = 0; i < max_index; i++) {
     // When cloning a tab, copy all entries except interstitial pages
     if (source.entries_[i].get()->GetPageType() !=
         content::PAGE_TYPE_INTERSTITIAL) {
       entries_.insert(entries_.begin() + insert_index++,
                       linked_ptr<NavigationEntryImpl>(
                           new NavigationEntryImpl(*source.entries_[i])));
     }
   }
 }