Support partitioning of storage contexts based on render_id.

chrome/browser/chrome_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_content_browser_client.h"
 
 #include <set>
 #include <utility>
 #include <vector>
 
@@ skipping 386 matching lines @@
   return main_parts;
 }
 
 content::WebContentsView*
     ChromeContentBrowserClient::OverrideCreateWebContentsView(
         WebContents* web_contents,
         content::RenderViewHostDelegateView** render_view_host_delegate_view) {
   return NULL;
 }
 
+std::string ChromeContentBrowserClient::GetStoragePartitionForChildProcess(
+    content::BrowserContext* browser_context,
+    int child_process_id) {

[Charlie Reis, 2012/07/02 23:21:23]

Let's add a comment explaining that Chrome uses the extension ID for any
isolated apps or extensions as the partition ID.

[awong, 2012/07/09 20:37:43]

Added...do we need to do any sort of prefixing?  like ia-EXTENSION_ID to avoid
future namespace collisions?  (eg., gt-STORAGE_PARTITION for guest tag).

[Charlie Reis, 2012/07/10 21:37:48]

I don't think prefixing is needed.

+  Profile* profile = Profile::FromBrowserContext(browser_context);
+  ExtensionService* extension_service =
+      ExtensionSystem::Get(profile)->extension_service();
+  if (extension_service) {
+    const extensions::Extension* installed_app = extension_service->
+        GetInstalledAppForRenderer(child_process_id);
+    if (installed_app != NULL && installed_app->is_storage_isolated()) {

[Charlie Reis, 2012/07/02 23:21:23]

Is this going to work with browser tags and other types of extensions with
isolated storage?  It should be consistent with how we handle cookies and cache,
and if those still need to be updated, that's fine.

[awong, 2012/07/09 20:37:43]

Cookies and cache should be migrated into the storage partition to make this all
consistent.  But I have to sort out the lifetime issues first.

As for browser tag, I hadn't realized there are CLs in yet to setup isolated
storage.  If so, I expect we will unify them when we migrate the
URLRequestContext into the StoragePartition.

[Charlie Reis, 2012/07/10 21:37:48]

No, Nasko's CL hasn't landed yet.  We can unify all those things as we go.

+      return installed_app->id();
+    }
+  }
+  return std::string();
+}
+
 content::WebContentsViewDelegate*
     ChromeContentBrowserClient::GetWebContentsViewDelegate(
         content::WebContents* web_contents) {
   return browser::CreateWebContentsViewDelegate(web_contents);
 }
 
 void ChromeContentBrowserClient::RenderViewHostCreated(
     RenderViewHost* render_view_host) {
 
   SiteInstance* site_instance = render_view_host->GetSiteInstance();
@@ skipping 1230 matching lines @@
     io_thread_application_locale_ = locale;
 }
 
 void ChromeContentBrowserClient::SetApplicationLocaleOnIOThread(
     const std::string& locale) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   io_thread_application_locale_ = locale;
 }
 
 }  // namespace chrome