Issue 10592022: Get rid of the multiple includes of browser_action_test_util files in browser.lib and browser_tests…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10592022: Get rid of the multiple includes of browser_action_test_util files in browser.lib and browser_tests… (Closed)

Created:
8 years, 6 months ago by jam

Modified:
8 years, 6 months ago

Reviewers:
scottmg

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Get rid of the multiple includes of browser_action_test_util files in browser.lib and browser_tests.exe. This is wrong on its own (we shouldn't be compiling code in/out using the UNIT_TEST ifdef). It also allows us to turn on incremental linking for browser_tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143272

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -45 lines)			Patch
M	chrome/browser/extensions/browser_action_test_util.h	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/browser_action_test_util_views.cc	View	2 chunks	+3 lines, -12 lines	0 comments	Download
M	chrome/browser/ui/views/browser_actions_container_browsertest.cc	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	chrome/chrome_tests.gypi	View	6 chunks	+0 lines, -18 lines	0 comments	Download
M	chrome/test/base/ui_test_utils.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/test/base/ui_test_utils.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages