[cros] Fake a stub user login when no --login-manager and --login-user are given.

chrome/browser/profiles/profile_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <set>
 
 #include "chrome/browser/profiles/profile_manager.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 146 matching lines @@
     ProfileManager::FindOrCreateNewWindowForProfile(
         profile,
         browser::startup::IS_PROCESS_STARTUP,
         browser::startup::IS_FIRST_RUN,
         false);
   }
 }
 
 } // namespace
 
+// static
+#if defined(OS_CHROMEOS)

[sail, 2012/06/22 18:46:56]

This code is getting increasingly hard to follow. It would be nice to clean this
up. Some things wrong with this:
  - it duplicates chrome::kInitialProfile
  - it's not referenced by any of the ProfileManager code that uses the default
profile
  - it adds more conditional logic to the profile code wich makes it more
fragile

Some suggestions:
  - can you change the value of chrome::kInitialProfile to "test-user" for
chrome os?
  - if not can you call ProfileManager::GetDafultProfile()->GetPath()->DirName()
  - if not can you make this a function of ProfileManager and update all
references to chrome::kInitialProfile?

+const char ProfileManager::kTestUserProfile[] = "test-user";
+#else
+const char ProfileManager::kTestUserProfile[] = "Default";
+#endif
+
 #if defined(ENABLE_SESSION_SERVICE)
 // static
 void ProfileManager::ShutdownSessionServices() {
   ProfileManager* pm = g_browser_process->profile_manager();
   if (!pm)  // Is NULL when running unit tests.
     return;
   std::vector<Profile*> profiles(pm->GetLoadedProfiles());
   for (size_t i = 0; i < profiles.size(); ++i)
     SessionServiceFactory::ShutdownForProfile(profiles[i]);
 }
@@ skipping 809 matching lines @@
 void ProfileManager::RunCallbacks(const std::vector<CreateCallback>& callbacks,
                                   Profile* profile,
                                   Profile::CreateStatus status) {
   for (size_t i = 0; i < callbacks.size(); ++i)
     callbacks[i].Run(profile, status);
 }
 
 ProfileManager::ProfileInfo::~ProfileInfo() {
   ProfileDestroyer::DestroyProfileWhenAppropriate(profile.release());
 }