Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Unified Diff: editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/util/BrowserManager.java

Issue 10590002: fix NPE while launch http://code.google.com/p/dart/issues/detail?id=3510 (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/util/BrowserManager.java
===================================================================
--- editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/util/BrowserManager.java (revision 8852)
+++ editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/util/BrowserManager.java (working copy)
@@ -172,9 +172,6 @@
devToolsPortNumber);
}
- stdout = readFromProcessPipes(browserName, browserProcess.getInputStream());
- stderr = readFromProcessPipes(browserName, browserProcess.getErrorStream());
-
BrowserHelper.activateApplication(dartium);
timer.stopTask();
@@ -583,6 +580,8 @@
}
browserProcess = process;
+ stdout = readFromProcessPipes(browserName, browserProcess.getInputStream());
+ stderr = readFromProcessPipes(browserName, browserProcess.getErrorStream());
}
private void terminateExistingBrowserProcess() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698