chrome/browser/ui/gtk/gtk_theme_service.cc - Issue 10584042: Bring up a content settings icon for ungestured registerProtocolHandler call.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/gtk_theme_service.cc

Issue 10584042: Bring up a content settings icon for ungestured registerProtocolHandler call. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make windows happy Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/content_settings/content_setting_image_model.cc ('K') | « chrome/browser/ui/content_settings/content_setting_image_model_unittest.cc ('k') | chrome/browser/ui/views/external_tab_container_win.cc » ('j') | chrome/browser/ui/webui/options2/content_settings_handler2.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/gtk_theme_service.cc

diff --git a/chrome/browser/ui/gtk/gtk_theme_service.cc b/chrome/browser/ui/gtk/gtk_theme_service.cc

index 3dc11d9a3b0bc08311d6889e8442b533b2792bd7..dcaec450e6f51676d5eb82174ba313c3357e1933 100644

--- a/chrome/browser/ui/gtk/gtk_theme_service.cc

+++ b/chrome/browser/ui/gtk/gtk_theme_service.cc

@@ -113,6 +113,7 @@ const int kAutocompleteImages[] = {

IDR_OMNIBOX_TTS_DARK,

IDR_GEOLOCATION_ALLOWED_LOCATIONBAR_ICON,

IDR_GEOLOCATION_DENIED_LOCATIONBAR_ICON,

+ IDR_REGISTER_PROTOCOL_HANDLER_LOCATIONBAR_ICON,

Peter Kasting 2012/06/25 23:55:30 Hmm, I'm not convinced the geolocation icons or th

Greg Billock 2012/06/26 19:17:04 Will do. Although Evan, do you know what these are

};

bool IsOverridableImage(int id) {

@@ -981,7 +982,8 @@ SkBitmap GtkThemeService::GenerateGtkThemeBitmap(int id) const {

case IDR_OMNIBOX_STAR:

case IDR_OMNIBOX_TTS:

case IDR_GEOLOCATION_ALLOWED_LOCATIONBAR_ICON:

- case IDR_GEOLOCATION_DENIED_LOCATIONBAR_ICON: {

+ case IDR_GEOLOCATION_DENIED_LOCATIONBAR_ICON:

+ case IDR_REGISTER_PROTOCOL_HANDLER_LOCATIONBAR_ICON: {

return GenerateTintedIcon(id, entry_tint_);

}

// In GTK mode, the dark versions of the omnibox icons only ever appear in