Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6849)

Unified Diff: chrome/browser/ui/views/select_file_dialog_extension.h

Issue 10584026: Allow ChromeOS file selection dialog to be shown from shell windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Uses BaseWindow instead of Browser Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/select_file_dialog_extension.h
diff --git a/chrome/browser/ui/views/select_file_dialog_extension.h b/chrome/browser/ui/views/select_file_dialog_extension.h
index eb91b0dcf8c898007ec6f8173950311a890fb88c..147648d0e0ebe6c2a117c23cc12158aff9c8dae8 100644
--- a/chrome/browser/ui/views/select_file_dialog_extension.h
+++ b/chrome/browser/ui/views/select_file_dialog_extension.h
@@ -14,8 +14,8 @@
#include "chrome/browser/ui/views/extensions/extension_dialog_observer.h"
#include "ui/gfx/native_widget_types.h" // gfx::NativeWindow
-class Browser;
class ExtensionDialog;
+class Profile;
namespace content {
class RenderViewHost;
@@ -89,13 +89,15 @@ class SelectFileDialogExtension
// Host for the extension that implements this dialog.
scoped_refptr<ExtensionDialog> extension_dialog_;
- // ID of the tab that spawned this dialog, used to route callbacks.
+ // ID of the tab that spawned this dialog, used to route callbacks. If the
+ // dialog is not associated with any browser it will be shown full screen,
+ // with the tab_id set to 0.
int32 tab_id_;
- // Cache a pointer to our owner browser. Since we're a child window of our
- // owner browser, if this browser gets deleted, it will also close us.
- Browser* owner_browser_;
+ // Pointer to the profile the dialog is running in.
+ Profile* profile_;
+ // The window that created the dialog.
gfx::NativeWindow owner_window_;
// We defer the callback into SelectFileDialog::Listener until the window

Powered by Google App Engine
This is Rietveld 408576698