Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: content/test/test_launcher.cc

Issue 10582012: For unit tests, track additions to AtExitManager and warn. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Additional fixes. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/test/test_switches.cc ('K') | « content/public/test/test_launcher.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/test_launcher.cc
diff --git a/content/test/test_launcher.cc b/content/test/test_launcher.cc
index ed4d8553c5763c3e524c825d090597bde36408f6..98cf4c01502174df40f47c13c79f656a382510c1 100644
--- a/content/test/test_launcher.cc
+++ b/content/test/test_launcher.cc
@@ -19,6 +19,7 @@
#include "base/string_number_conversions.h"
#include "base/string_util.h"
#include "base/test/test_suite.h"
+#include "base/test/test_switches.h"
#include "base/test/test_timeouts.h"
#include "base/time.h"
#include "base/utf_string_conversions.h"
@@ -342,7 +343,7 @@ int RunTest(TestLauncherDelegate* launcher_delegate,
// tests unless this flag was specified to the browser test executable.
new_cmd_line.AppendSwitch("gtest_also_run_disabled_tests");
new_cmd_line.AppendSwitchASCII("gtest_filter", test_name);
- new_cmd_line.AppendSwitch(kSingleProcessTestsFlag);
+ new_cmd_line.AppendSwitch(switches::kSingleProcessTestsFlag);
// Do not let the child ignore failures. We need to propagate the
// failure status back to the parent.
@@ -566,8 +567,6 @@ const char kGTestRepeatFlag[] = "gtest_repeat";
const char kGTestRunDisabledTestsFlag[] = "gtest_also_run_disabled_tests";
const char kGTestOutputFlag[] = "gtest_output";
-const char kSingleProcessTestsFlag[] = "single_process";
-const char kSingleProcessTestsAndChromeFlag[] = "single-process";
// The following is kept for historical reasons (so people that are used to
// using it don't get surprised).
const char kChildProcessFlag[] = "child";
@@ -594,12 +593,12 @@ int LaunchTests(TestLauncherDelegate* launcher_delegate,
// terrible UI. Instead, there should be some sort of signal flag on the
// command line, with all subsequent arguments passed through to the
// underlying browser.
- if (command_line->HasSwitch(kSingleProcessTestsFlag) ||
- command_line->HasSwitch(kSingleProcessTestsAndChromeFlag) ||
+ if (command_line->HasSwitch(switches::kSingleProcessTestsFlag) ||
+ command_line->HasSwitch(switches::kSingleProcessChromeFlag) ||
command_line->HasSwitch(kGTestListTestsFlag) ||
command_line->HasSwitch(kGTestHelpFlag)) {
#if defined(OS_WIN)
- if (command_line->HasSwitch(kSingleProcessTestsFlag)) {
+ if (command_line->HasSwitch(switches::kSingleProcessTestsFlag)) {
sandbox::SandboxInterfaceInfo sandbox_info;
content::InitializeSandboxInfo(&sandbox_info);
content::InitializeSandbox(&sandbox_info);
« base/test/test_switches.cc ('K') | « content/public/test/test_launcher.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698