For unit tests, track additions to AtExitManager and warn.

base/at_exit.h

Index: base/at_exit.h
diff --git a/base/at_exit.h b/base/at_exit.h
index 613c9fe7d1729f8a9590e50abc3f8547c0676bb8..bdfad8ca275a4d5c95924246594c30bf3d6e1793 100644
--- a/base/at_exit.h
+++ b/base/at_exit.h
@@ -15,6 +15,8 @@
 
 namespace base {
 
+class TestWatchAtExitManager;
+
 // This class provides a facility similar to the CRT atexit(), except that
 // we control when the callbacks are executed. Under Windows for a DLL they
 // happen at a really bad time and under the loader lock. This facility is
@@ -58,6 +60,11 @@ class BASE_EXPORT AtExitManager {
   explicit AtExitManager(bool shadow);
 
  private:
+  friend class TestWatchAtExitManager;
+
+  static void* CurrentAtExitManager();

[Paweł Hajdan Jr., 2012/06/21 08:45:24]

nit: Let's not repeat the name, just static AtExitManager* current();

[Scott Byer, 2012/06/21 21:35:01]

Done.

+  static size_t CurrentAtExitCallbackStackSize();

[Paweł Hajdan Jr., 2012/06/21 08:45:24]

nit: Let's remove the static and just name this CallbackStackSize() const;

[Scott Byer, 2012/06/21 21:35:01]

Done.

+
   base::Lock lock_;
   std::stack<base::Closure> stack_;
   AtExitManager* next_manager_;  // Stack of managers to allow shadowing.