For unit tests, track additions to AtExitManager and warn.

content/public/test/test_renderer_host.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_TEST_TEST_RENDERER_HOST_H_
 #define CONTENT_PUBLIC_TEST_TEST_RENDERER_HOST_H_
 #pragma once
 
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
+#include "base/test/unit_test.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/common/page_transition_types.h"
-#include "testing/gtest/include/gtest/gtest.h"
 
 #if defined(USE_AURA)
 #include "ui/aura/test/aura_test_helper.h"
 #endif
 
 namespace aura {
 namespace test {
 class AuraTestHelper;
 }
 }
@@ skipping 87 matching lines @@
 
  private:
   DISALLOW_COPY_AND_ASSIGN(RenderViewHostTestEnabler);
   friend class RenderViewHostTestHarness;
 
   scoped_ptr<MockRenderProcessHostFactory> rph_factory_;
   scoped_ptr<TestRenderViewHostFactory> rvh_factory_;
 };
 
 // RenderViewHostTestHarness ---------------------------------------------------
-class RenderViewHostTestHarness : public testing::Test {
+class RenderViewHostTestHarness : public base::UnitTest {

[Scott Byer, 2012/06/18 23:45:57]

This is the test harness that surrounds both the new unit test I was working on
and one of the unit_tests I saw a problem with. I suspect there are other
subclasses of testing::Test that should also be lifted up and adhere to the
invariant.

  public:
   RenderViewHostTestHarness();
   virtual ~RenderViewHostTestHarness();
 
   NavigationController& controller();
   virtual WebContents* web_contents();
   RenderViewHost* rvh();
   RenderViewHost* pending_rvh();
   RenderViewHost* active_rvh();
   BrowserContext* browser_context();
@@ skipping 46 matching lines @@
   scoped_ptr<aura::test::AuraTestHelper> aura_test_helper_;
 #endif
   RenderViewHostTestEnabler rvh_test_enabler_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderViewHostTestHarness);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_TEST_TEST_RENDERER_HOST_H_