Moving LoadFromMemoryCacheDetails to content/public/browser and making it a struct.

content/public/browser/load_from_memory_cache_details.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_BROWSER_LOAD_FROM_MEMORY_CACHE_DETAILS_H_
+#define CONTENT_PUBLIC_BROWSER_LOAD_FROM_MEMORY_CACHE_DETAILS_H_
+#pragma once
+
+#include <string>
+#include "base/basictypes.h"
+#include "googleurl/src/gurl.h"
+#include "net/base/cert_status_flags.h"
+#include "webkit/glue/resource_type.h"
+
+namespace content {
+
+struct LoadFromMemoryCacheDetails {
+  LoadFromMemoryCacheDetails(const GURL& url,

[jam, 2012/06/18 23:29:01]

nit: is this constructor still needed? we try to avoid cc files in
content/public unless needed to avoid clang errors. or if you just want to keep
it, can we inline this?

[Shishir, 2012/06/18 23:53:46]

I had tried to inline it, but I get the - Complex struct with inline constructor
- clang error.

In my past code reviews, reviewers have asked me to keep a constructor for
structs  as they have said that the default values of the fields may cause bugs
if not initialized properly. I can get rid of the constructor if you think that
its not an issue.

[jam, 2012/06/19 00:04:57]

I don't see how this constructor helps with that issue, since it's not a default
constructor?

Yeah I'd prefer to get rid of it so we can avoid a cc file (we try hard to avoid
cc files in content/public)

+                             int pid,
+                             int cert_id,
+                             net::CertStatus cert_status,
+                             const std::string& http_method,
+                             const std::string& mime_type,
+                             ResourceType::Type resource_type);
+  ~LoadFromMemoryCacheDetails();
+
+  GURL url;
+  int pid;
+  int cert_id;
+  net::CertStatus cert_status;
+  std::string http_method;
+  std::string mime_type;
+  ResourceType::Type resource_type;
+};
+
+}  // namespace content
+
+#endif  // CONTENT_PUBLIC_BROWSER_LOAD_FROM_MEMORY_CACHE_DETAILS_H_