Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome/browser/chromeos/gdata/gdata_file_system.cc

Issue 10581038: chromeos: Stop returning scoped_ptr from GDataCache::GetCacheEntry (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: _ Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/gdata/gdata_file_system.cc
diff --git a/chrome/browser/chromeos/gdata/gdata_file_system.cc b/chrome/browser/chromeos/gdata/gdata_file_system.cc
index 230ae9d49bae60efc56e8b11d81a45648c661b31..2b27a5ae7a7267d72097c185e0786c3edfffb98a 100644
--- a/chrome/browser/chromeos/gdata/gdata_file_system.cc
+++ b/chrome/browser/chromeos/gdata/gdata_file_system.cc
@@ -198,11 +198,7 @@ void GetCacheEntryOnBlockingPool(
const std::string& md5,
GDataCache::CacheEntry* cache_entry,
bool* success) {
- scoped_ptr<GDataCache::CacheEntry> value(
- cache->GetCacheEntry(resource_id, md5));
- *success = value.get();
- if (*success)
- *cache_entry = *value;
+ *success = cache->GetCacheEntry(resource_id, md5, cache_entry);
satorux1 2012/06/20 15:29:23 nice! it's simpler
}
// Runs GetFileCallback with pointers dereferenced.

Powered by Google App Engine
This is Rietveld 408576698