Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3597)

Unified Diff: chrome/browser/chromeos/gdata/gdata_cache_metadata.h

Issue 10581038: chromeos: Stop returning scoped_ptr from GDataCache::GetCacheEntry (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase and review fix Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/gdata/gdata_cache_metadata.h
diff --git a/chrome/browser/chromeos/gdata/gdata_cache_metadata.h b/chrome/browser/chromeos/gdata/gdata_cache_metadata.h
index e45132c49c4142419e9db0c76566e278141c9828..e1533be2c1fd75600caf3fd21474625dfd3ceb8a 100644
--- a/chrome/browser/chromeos/gdata/gdata_cache_metadata.h
+++ b/chrome/browser/chromeos/gdata/gdata_cache_metadata.h
@@ -45,14 +45,14 @@ class GDataCacheMetadata {
// Removes entry corresponding to |resource_id| from cache map.
virtual void RemoveFromCache(const std::string& resource_id) = 0;
- // Returns the cache entry for file corresponding to |resource_id| and |md5|
- // if entry exists in cache map. Otherwise, returns NULL.
+ // Gets the cache entry for file corresponding to |resource_id| and |md5|
+ // and returns true if entry exists in cache map. Otherwise, returns false.
// |md5| can be empty if only matching |resource_id| is desired, which may
// happen when looking for pinned entries where symlinks' filenames have no
// extension and hence no md5.
- virtual scoped_ptr<GDataCache::CacheEntry> GetCacheEntry(
- const std::string& resource_id,
- const std::string& md5) = 0;
+ virtual bool GetCacheEntry(const std::string& resource_id,
+ const std::string& md5,
+ GDataCache::CacheEntry* entry) = 0;
// Removes temporary files (files in CACHE_TYPE_TMP) from the cache map.
virtual void RemoveTemporaryFiles() = 0;
@@ -89,9 +89,9 @@ class GDataCacheMetadataMap : public GDataCacheMetadata {
const std::string& md5,
int cache_state) OVERRIDE;
virtual void RemoveFromCache(const std::string& resource_id) OVERRIDE;
- virtual scoped_ptr<GDataCache::CacheEntry> GetCacheEntry(
- const std::string& resource_id,
- const std::string& md5) OVERRIDE;
+ virtual bool GetCacheEntry(const std::string& resource_id,
+ const std::string& md5,
+ GDataCache::CacheEntry* entry) OVERRIDE;
virtual void RemoveTemporaryFiles() OVERRIDE;
virtual void Iterate(const IterateCallback& callback) OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698