Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: chrome/browser/chromeos/gdata/gdata_cache.h

Issue 10581038: chromeos: Stop returning scoped_ptr from GDataCache::GetCacheEntry (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/gdata/gdata_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/gdata/gdata_cache.h
diff --git a/chrome/browser/chromeos/gdata/gdata_cache.h b/chrome/browser/chromeos/gdata/gdata_cache.h
index dd29b269df5903ee6cd0dd244f39fcc8ae3d7019..b6d4a3371223ce42971beeea93ae7e4584078f21 100644
--- a/chrome/browser/chromeos/gdata/gdata_cache.h
+++ b/chrome/browser/chromeos/gdata/gdata_cache.h
@@ -251,13 +251,14 @@ class GDataCache {
// Utility method to call Initialize on UI thread.
void RequestInitializeOnUIThread();
- // Returns the cache entry for file corresponding to |resource_id| and |md5|
- // if entry exists in cache map. Otherwise, returns NULL.
+ // Gets the cache entry for file corresponding to |resource_id| and |md5|
+ // and returns true if entry exists in cache map. Otherwise, returns false.
// |md5| can be empty if only matching |resource_id| is desired, which may
// happen when looking for pinned entries where symlinks' filenames have no
// extension and hence no md5.
- scoped_ptr<GDataCacheEntry> GetCacheEntry(const std::string& resource_id,
- const std::string& md5);
+ bool GetCacheEntry(const std::string& resource_id,
+ const std::string& md5,
+ GDataCacheEntry* entry);
// Factory methods for GDataCache.
// |pool| and |sequence_token| are used to assert that the functions are
« no previous file with comments | « no previous file | chrome/browser/chromeos/gdata/gdata_cache.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698