chrome/browser/ui/views/omnibox/omnibox_view_win.cc - Issue 10580039: Adds ability to render omnibox as a view above the page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_win.cc

Issue 10580039: Adds ability to render omnibox as a view above the page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix windows Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/omnibox/omnibox_view_win.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_win.cc b/chrome/browser/ui/views/omnibox/omnibox_view_win.cc

index a317a82a0c0cb503bc05642016a30480d2e766e5..f1e73bf8940769ff2b0f1c3612302897afecc01d 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_win.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_win.cc

@@ -438,11 +438,13 @@ OmniboxViewWin::OmniboxViewWin(AutocompleteEditController* controller,

LocationBarView* parent_view,

CommandUpdater* command_updater,

bool popup_window_mode,

- views::View* location_bar)

+ views::View* location_bar,

+ views::View* popup_parent_view)

: model_(new AutocompleteEditModel(this, controller,

parent_view->profile())),

- popup_view_(OmniboxPopupContentsView::CreateForEnvironment(

- parent_view->font(), this, model_.get(), location_bar)),

+ popup_view_(OmniboxPopupContentsView::Create(

+ parent_view->font(), this, model_.get(), location_bar,

+ popup_parent_view)),

controller_(controller),

parent_view_(parent_view),

toolbar_model_(toolbar_model),