Issue 10580033: Allow AudioDevice to be constructed on any thread

Issue 10580033: Allow AudioDevice to be constructed on any thread (Closed)

Created:
8 years, 6 months ago by Chris Rogers

Modified:
8 years, 5 months ago

Reviewers:
tommi (sloooow) - chröme, henrika (OOO until Aug 14), scherkus (not reviewing)

CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, jochen+watch-content_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Allow AudioDevice to be constructed on any thread

Patch Set 2 : #

Total comments: 6

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -2 lines)			Patch
M	content/renderer/media/audio_device.cc	View	2 chunks	+2 lines, -2 lines	2 comments	Download
M	content/renderer/media/audio_message_filter.h	View	2 chunks	+6 lines, -0 lines	2 comments	Download
M	content/renderer/media/audio_message_filter.cc	View	1 chunk	+4 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tommi (sloooow) - chröme

https://chromiumcodereview.appspot.com/10580033/diff/1001/content/renderer/media/audio_message_filter.cc File content/renderer/media/audio_message_filter.cc (right): https://chromiumcodereview.appspot.com/10580033/diff/1001/content/renderer/media/audio_message_filter.cc#newcode14 content/renderer/media/audio_message_filter.cc:14: AudioMessageFilter* AudioMessageFilter::filter_ = 0; s/0/NULL https://chromiumcodereview.appspot.com/10580033/diff/1001/content/renderer/media/audio_message_filter.cc#newcode20 content/renderer/media/audio_message_filter.cc:20: filter_ = ...

8 years, 6 months ago (2012-06-20 07:48:30 UTC) #1

henrika (OOO until Aug 14)

https://chromiumcodereview.appspot.com/10580033/diff/1001/content/renderer/media/audio_device.cc File content/renderer/media/audio_device.cc (right): https://chromiumcodereview.appspot.com/10580033/diff/1001/content/renderer/media/audio_device.cc#newcode49 content/renderer/media/audio_device.cc:49: filter_ = AudioMessageFilter::current(); By not injecting you make it ...

8 years, 6 months ago (2012-06-20 12:33:51 UTC) #2

henrika (OOO until Aug 14)

http://codereview.chromium.org/10580033/diff/1001/content/renderer/media/audio_device.cc File content/renderer/media/audio_device.cc (right): http://codereview.chromium.org/10580033/diff/1001/content/renderer/media/audio_device.cc#newcode49 content/renderer/media/audio_device.cc:49: filter_ = AudioMessageFilter::current(); Bad example; sorry. I meant create ...

8 years, 6 months ago (2012-06-20 17:15:53 UTC) #3

scherkus (not reviewing)

8 years, 5 months ago (2012-06-27 04:44:27 UTC) #4

Closing this issue seeing as henrika@'s CL has incorporated this change -- I
like a clean issue list :)

Expand Messages | Collapse Messages