Fix edit profile link in NTP

chrome/browser/resources/options2/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
 
   //
@@ skipping 219 matching lines @@
         profilesList.autoExpands = true;
 
         this.setProfilesInfo_(loadTimeData.getValue('profilesInfo'));
 
         profilesList.addEventListener('change',
             this.setProfileViewButtonsStatus_);
         $('profiles-create').onclick = function(event) {
           chrome.send('createProfile');
         };
         $('profiles-manage').onclick = function(event) {
-          var selectedProfile = self.getSelectedProfileItem_();
-          if (selectedProfile)
-            ManageProfileOverlay.showManageDialog(selectedProfile);
+          ManageProfileOverlay.showManageDialog();
         };
         $('profiles-delete').onclick = function(event) {
           var selectedProfile = self.getSelectedProfileItem_();
           if (selectedProfile)
             ManageProfileOverlay.showDeleteDialog(selectedProfile);
         };
       }
 
       if (cr.isChromeOS) {
         if (!UIAccountTweaks.loggedInAsGuest()) {
@@ skipping 743 matching lines @@
      * @param {Array.<Object>} profiles An array of profile info objects.
      *     each object is of the form:
      *       profileInfo = {
      *         name: "Profile Name",
      *         iconURL: "chrome://path/to/icon/image",
      *         filePath: "/path/to/profile/data/on/disk",
      *         isCurrentProfile: false
      *       };
      * @private
      */
     setProfilesInfo_: function(profiles) {

[Dan Beam, 2012/06/19 23:44:25]

if |profiles| can be null, handle this

[Evan Stade, 2012/06/20 02:04:31]

shouldn't be possible.

       this.setProfileViewSingle_(profiles.length);
       // add it to the list, even if the list is hidden so we can access it
       // later.
       $('profiles-list').dataModel = new ArrayDataModel(profiles);
-      // We got new data, close the open overlay if it's open.
-      ManageProfileOverlay.getInstance().visible = false;
+
+      // We got new data. If we are showing the "manage" overlay, keep it up to

[Dan Beam, 2012/06/19 23:44:25]

we use "we" three times, here. are we going to change that?

[Evan Stade, 2012/06/20 02:04:31]

Done.

+      // date. If we are showing the "delete" overlay, close it.
+      if (ManageProfileOverlay.getInstance().visible &&
+          !$('manage-profile-overlay-manage').hidden) {
+        ManageProfileOverlay.showManageDialog();
+      } else {
+        ManageProfileOverlay.getInstance().visible = false;
+      }
+
       this.setProfileViewButtonsStatus_();
     },
 
+    /**
+     * Returns the currently active profile for this browser window.
+     * @return {Object} A profile info object.

[Dan Beam, 2012/06/19 23:44:25]

{?Object} unless you really can't return null.

+     * @private
+     */
+    getCurrentProfile_: function() {
+      for (var i = 0; i < $('profiles-list').dataModel.length; i++) {
+        if ($('profiles-list').dataModel.item(i).isCurrentProfile)

[Dan Beam, 2012/06/19 23:44:25]

  var profile = $('profiles-list').dataModel.item(i);
  if (profile.isCurrentProfile)
    return profile;

[Evan Stade, 2012/06/20 02:04:31]

Done.

+          return $('profiles-list').dataModel.item(i);
+      }
+
+      return null;

[Dan Beam, 2012/06/19 23:44:25]

  assert(false, "couldn't find a default profile");

as I don't think there's a case where at least one profile exists that is
current, OR if that's possible handle this better in downstream code.

[Evan Stade, 2012/06/20 02:04:31]

it's not default, it's current.

done.

[Dan Beam, 2012/06/20 02:22:07]

sorry, yeah, one was right, :)

+    },
+
     setGtkThemeButtonEnabled_: function(enabled) {
       if (!cr.isChromeOS && navigator.platform.match(/linux|BSD/i))
         $('themes-GTK-button').disabled = !enabled;
     },
 
     setThemesResetButtonEnabled_: function(enabled) {
       $('themes-reset').disabled = !enabled;
     },
 
     /**
@@ skipping 326 matching lines @@
     setContentFilterSettingsValue_: function(dict) {
       if ('cookies' in dict && 'value' in dict['cookies'])
         this.sessionOnlyCookies_ = dict['cookies']['value'] == 'session';
     }
 
   };
 
   //Forward public APIs to private implementations.
   [
     'addBluetoothDevice',
+    'getCurrentProfile',
     'getStartStopSyncButton',
     'hideBluetoothSettings',
     'removeCloudPrintConnectorSection',
     'removeBluetoothDevice',
     'setAutoOpenFileTypesDisplayed',
     'setBackgroundModeCheckboxState',
     'setBluetoothState',
     'setCheckRevocationCheckboxState',
     'setContentFilterSettingsValue',
     'setFontSize',
@@ skipping 36 matching lines @@
     BrowserOptions.getLoggedInUsername = function() {
       return BrowserOptions.getInstance().username_;
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });