Add NVCtrl header files.

Add NVCtrl header files.

BUG=
TEST=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=143321

[Zhenyao Mo, 2012-06-20 20:42:27]

On 2012/06/20 20:40:09, Zhenyao Mo wrote:

Mark, I am trying to check NVCtrl.h and NVCtrlLib.h in so I can use nv-control
extension in chromium.

I prepared the LICENSE by copying from the header files.  Since one is 2008 and
2010, so I put 2008/2010 in the LICENSE file.  Is it the right thing to do?

Also, for the README.chromium, what should I say in the line "license"?

Thank you.

[Ken Russell (switch to Gerrit), 2012-06-20 21:57:54]

http://codereview.chromium.org/10578052/diff/1/third_party/nvidia/NVCtrlLib.h
File third_party/nvidia/NVCtrlLib.h (right):

http://codereview.chromium.org/10578052/diff/1/third_party/nvidia/NVCtrlLib.h...
third_party/nvidia/NVCtrlLib.h:42: Bool XNVCTRLQueryExtension (
How are these functions going to be called? Presumably we can dynamically look
up their entry points?

http://codereview.chromium.org/10578052/diff/1/third_party/nvidia/README.chro...
File third_party/nvidia/README.chromium (right):

http://codereview.chromium.org/10578052/diff/1/third_party/nvidia/README.chro...
third_party/nvidia/README.chromium:3: URL: http://www.nvidia.org/
Please provide a more detailed URL than this so that other people can update
these headers if necessary.

http://codereview.chromium.org/10578052/diff/1/third_party/nvidia/README.chro...
third_party/nvidia/README.chromium:6: License:
This needs to be filled in. A search indicates that this code is using the MIT
license. Did you make sure these files pass the licensecheck script?

http://codereview.chromium.org/10578052/diff/1/third_party/nvidia/README.chro...
third_party/nvidia/README.chromium:10: This package contains header files for
NVCtrl extension.
Indicate that it is used to determine the version of the NVIDIA driver in use.

[Zhenyao Mo, 2012-06-20 22:24:42]

Uploaded the whole lib instead of just the header file.

http://codereview.chromium.org/10578052/diff/1/third_party/nvidia/NVCtrlLib.h
File third_party/nvidia/NVCtrlLib.h (right):

http://codereview.chromium.org/10578052/diff/1/third_party/nvidia/NVCtrlLib.h...
third_party/nvidia/NVCtrlLib.h:42: Bool XNVCTRLQueryExtension (
On 2012/06/20 21:57:55, kbr wrote:
> How are these functions going to be called? Presumably we can dynamically look
> up their entry points?

I checked the whole lib including the .c file.  They will be built into
chromium.

http://codereview.chromium.org/10578052/diff/1/third_party/nvidia/README.chro...
File third_party/nvidia/README.chromium (right):

http://codereview.chromium.org/10578052/diff/1/third_party/nvidia/README.chro...
third_party/nvidia/README.chromium:3: URL: http://www.nvidia.org/
On 2012/06/20 21:57:55, kbr wrote:
> Please provide a more detailed URL than this so that other people can update
> these headers if necessary.

Done.

http://codereview.chromium.org/10578052/diff/1/third_party/nvidia/README.chro...
third_party/nvidia/README.chromium:6: License:
On 2012/06/20 21:57:55, kbr wrote:
> This needs to be filled in. A search indicates that this code is using the MIT
> license. Did you make sure these files pass the licensecheck script?

I ran "tools/licenses.py scan" and see no problem.  Is this what you are talking
about?

http://codereview.chromium.org/10578052/diff/1/third_party/nvidia/README.chro...
third_party/nvidia/README.chromium:10: This package contains header files for
NVCtrl extension.
On 2012/06/20 21:57:55, kbr wrote:
> Indicate that it is used to determine the version of the NVIDIA driver in use.

Done.

[Ken Russell (switch to Gerrit), 2012-06-20 22:42:43]

http://codereview.chromium.org/10578052/diff/1/third_party/nvidia/NVCtrlLib.h
File third_party/nvidia/NVCtrlLib.h (right):

http://codereview.chromium.org/10578052/diff/1/third_party/nvidia/NVCtrlLib.h...
third_party/nvidia/NVCtrlLib.h:42: Bool XNVCTRLQueryExtension (
On 2012/06/20 22:24:42, Zhenyao Mo wrote:
> On 2012/06/20 21:57:55, kbr wrote:
> > How are these functions going to be called? Presumably we can dynamically
look
> > up their entry points?
> 
> I checked the whole lib including the .c file.  They will be built into
> chromium.

Is there any possibility that these symbols will collide with any provided by
NVIDIA's binary driver (and consequently dynamically loaded into the Chrome
process)?

http://codereview.chromium.org/10578052/diff/1/third_party/nvidia/README.chro...
File third_party/nvidia/README.chromium (right):

http://codereview.chromium.org/10578052/diff/1/third_party/nvidia/README.chro...
third_party/nvidia/README.chromium:6: License:
On 2012/06/20 22:24:42, Zhenyao Mo wrote:
> On 2012/06/20 21:57:55, kbr wrote:
> > This needs to be filled in. A search indicates that this code is using the
MIT
> > license. Did you make sure these files pass the licensecheck script?
> 
> I ran "tools/licenses.py scan" and see no problem.  Is this what you are
talking
> about?

Actually it's src/tools/checklicenses/checklicenses.py . Please run that in
verbose mode and make absolutely sure it is scanning the sources in this
directory and that they pass. Otherwise this commit will break the Linux bots
(those are the only ones that run the checklicenses step).

[Zhenyao Mo, 2012-06-21 00:00:38]

On 2012/06/20 22:42:43, kbr wrote:
> http://codereview.chromium.org/10578052/diff/1/third_party/nvidia/NVCtrlLib.h
> File third_party/nvidia/NVCtrlLib.h (right):
> 
>
http://codereview.chromium.org/10578052/diff/1/third_party/nvidia/NVCtrlLib.h...
> third_party/nvidia/NVCtrlLib.h:42: Bool XNVCTRLQueryExtension (
> On 2012/06/20 22:24:42, Zhenyao Mo wrote:
> > On 2012/06/20 21:57:55, kbr wrote:
> > > How are these functions going to be called? Presumably we can dynamically
> look
> > > up their entry points?
> > 
> > I checked the whole lib including the .c file.  They will be built into
> > chromium.
> 
> Is there any possibility that these symbols will collide with any provided by
> NVIDIA's binary driver (and consequently dynamically loaded into the Chrome
> process)?

I built and ran on Linux/NVIDIA, no conflicts.

> 
>
http://codereview.chromium.org/10578052/diff/1/third_party/nvidia/README.chro...
> File third_party/nvidia/README.chromium (right):
> 
>
http://codereview.chromium.org/10578052/diff/1/third_party/nvidia/README.chro...
> third_party/nvidia/README.chromium:6: License:
> On 2012/06/20 22:24:42, Zhenyao Mo wrote:
> > On 2012/06/20 21:57:55, kbr wrote:
> > > This needs to be filled in. A search indicates that this code is using the
> MIT
> > > license. Did you make sure these files pass the licensecheck script?
> > 
> > I ran "tools/licenses.py scan" and see no problem.  Is this what you are
> talking
> > about?
> 
> Actually it's src/tools/checklicenses/checklicenses.py . Please run that in
> verbose mode and make absolutely sure it is scanning the sources in this
> directory and that they pass. Otherwise this commit will break the Linux bots
> (those are the only ones that run the checklicenses step).

ran it, below are the output:


/usr/local/google/home/zmo/chrome/src/third_party/libXNVCtrl/NVCtrl.c: MIT/X11
(BSD like) 
/usr/local/google/home/zmo/chrome/src/third_party/libXNVCtrl/NVCtrlLib.h:
MIT/X11 (BSD like) 
/usr/local/google/home/zmo/chrome/src/third_party/libXNVCtrl/nv_control.h:
MIT/X11 (BSD like) 
/usr/local/google/home/zmo/chrome/src/third_party/libXNVCtrl/NVCtrl.h: MIT/X11
(BSD like)

[Ken Russell (switch to Gerrit), 2012-06-21 00:19:32]

OK, thanks. LGTM

[Mark Larson, 2012-06-21 01:04:11]

LGTM