Extensions Docs Server: HandlebarDictGenerator

chrome/common/extensions/docs/server2/template_data_source.py

Index: chrome/common/extensions/docs/server2/template_data_source.py
diff --git a/chrome/common/extensions/docs/server2/template_data_source.py b/chrome/common/extensions/docs/server2/template_data_source.py
index a2e1b69a92dace03f3e80173d2ae64249e4e4cce..23ec715f94234dc385d66a23b0d20e3b88738ff6 100644
--- a/chrome/common/extensions/docs/server2/template_data_source.py
+++ b/chrome/common/extensions/docs/server2/template_data_source.py
@@ -24,7 +24,7 @@ class TemplateDataSource(object):
     if not template:
       return ''
       # TODO error handling
-    return template.render(context, {'templates': self}).text
+    return template.render(context, self).text

[not at google - send to devlin, 2012/06/20 18:11:53]

Why this change? Unless I'm misunderstanding, it means that any misspelled
variable name in the templates will fall through to here, which will grab stuff
from the fetcher.

I guess that's not a big deal provided we cache cache-misses too (do we?).

But I also just kinda like the fact that the sub-templates are namespaced. Avoid
potential problems with overriding references in the templates later on.

[cduvall, 2012/06/20 18:24:49]

Yeah, I changed this because I thought it would work better (and didn't
completely understand partials at the time), but  I changed it back when I was
messing with implementing a sample template.

 
   def __getitem__(self, key):
     return self.get(key)