VariationsService now supports wildcard in min/max version

base/version.h

Index: base/version.h
===================================================================
--- base/version.h	(revision 142948)
+++ base/version.h	(working copy)
@@ -30,6 +30,10 @@
   // Returns true if the object contains a valid version number.
   bool IsValid() const;
 
+  // Returns true if the version string is valid. In this version, the string
+  // can end with a wildcard character.

[Alexei Svitkine (slow), 2012/06/19 14:53:17]

Please reword this. "In this version," is very confusing here. There is no need
to refer to the current state of the code as "in this version" - just state
exactly what it does and what is valid and invalid.

[Mathieu, 2012/06/19 18:29:06]

Done.

+  static bool IsValidWildcard(const std::string& version_str);
+
   // Commonly used pattern. Given a valid version object, compare if a
   // |version_str| results in a newer version. Returns true if the
   // string represents valid version and if the version is greater than
@@ -50,6 +54,11 @@
   // Returns -1, 0, 1 for <, ==, >.
   int CompareTo(const Version& other) const;
 
+  // Given a valid version object, compare if a |version_str| results in a
+  // newer version. This function will default to CompareTo if the string does
+  // not end in a wildcard character "*".

[Alexei Svitkine (slow), 2012/06/19 14:53:17]

Please document the requirement that IsValidWildcard(version_str) must be true
before calling this function.

Also, suggest renaming names and variables throughout to refer to
"wildcard_string", e.g.:

CompareToWildcardString(const std::string& wildcard_string)

and

IsValidWildcardString(const std::string& wildcard_string) and elsewhere.

[Mathieu, 2012/06/19 18:29:06]

Done.

+  int CompareToWildcard(const std::string& version_str) const;
+
   // Return the string representation of this version.
   const std::string GetString() const;