Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: base/version.h

Issue 10576003: VariationsService now supports wildcard in min/max version (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Addressed comments Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/version.cc » ('j') | base/version.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/version.h
===================================================================
--- base/version.h (revision 143914)
+++ base/version.h (working copy)
@@ -30,6 +30,12 @@
// Returns true if the object contains a valid version number.
bool IsValid() const;
+ // Returns true if the version string is valid. The version string
Alexei Svitkine (slow) 2012/06/26 18:22:03 Nit: "version string" -> "version wildcard string"
Mathieu 2012/06/27 15:40:06 Done.
+ // may end with ".*" (e.g. 1.2.*, 1.*). Any other arrangement with "*" will
+ // be invalid (e.g. 1.*.3 or 1.2.3*). This functions defaults to standard
Alexei Svitkine (slow) 2012/06/26 18:22:03 Nit: Rephrase "will be" to "is".
Mathieu 2012/06/27 15:40:06 Done.
+ // Version behavior (IsValid) if no wildcard is present.
+ static bool IsValidWildcardString(const std::string& wildcard_string);
+
// Commonly used pattern. Given a valid version object, compare if a
// |version_str| results in a newer version. Returns true if the
// string represents valid version and if the version is greater than
@@ -50,6 +56,12 @@
// Returns -1, 0, 1 for <, ==, >.
int CompareTo(const Version& other) const;
+ // Given a valid version object, compare if a |wildcard_string| results in a
+ // newer version. This function will default to CompareTo if the string does
+ // not end in wildcard sequence ".*". IsValidWildcard(wildcard_string) must be
+ // true before using this function.
+ int CompareToWildcardString(const std::string& wildcard_string) const;
+
// Return the string representation of this version.
const std::string GetString() const;
« no previous file with comments | « no previous file | base/version.cc » ('j') | base/version.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698