VariationsService now supports wildcard in min/max version

base/version.cc

Index: base/version.cc
===================================================================
--- base/version.cc	(revision 142948)
+++ base/version.cc	(working copy)
@@ -11,33 +11,73 @@
 #include "base/string_split.h"
 #include "base/string_util.h"
 
-Version::Version() {
-}
+namespace {
 
-Version::~Version() {
-}
-
-Version::Version(const std::string& version_str) {
+// This function parses the |numbers| vector representing the different numbers
+// inside the version string and constructs a vector of valid integers. It stops
+// when it reaches an invalid item (including the wildcard character). |parsed|
+// is the resulting integer vector. Function returns true if all numbers were
+// parsed successfully, false otherwise.
+bool ParseVersionNumbers(const std::string& version_str,
+                         std::vector<uint16>& parsed) {
   std::vector<std::string> numbers;
   base::SplitString(version_str, '.', &numbers);
   if (numbers.empty())
-    return;
-  std::vector<uint16> parsed;
-  for (std::vector<std::string>::iterator i = numbers.begin();
+    return false;
+  for (std::vector<std::string>::const_iterator i = numbers.begin();
        i != numbers.end(); ++i) {
     int num;
     if (!base::StringToInt(*i, &num))
-      return;
+      return false;
     if (num < 0)
-      return;
+      return false;
     const uint16 max = 0xFFFF;
     if (num > max)
-      return;
+      return false;
     // This throws out things like +3, or 032.
     if (base::IntToString(num) != *i)
-      return;
+      return false;
     parsed.push_back(static_cast<uint16>(num));
   }
+  return true;
+}
+
+// Compares version components in |comp1| with components in |comp2|. Returns
+// -1, 0 or 1 if comp2 is less than, equal to, or greater than comp1,

[Alexei Svitkine (slow), 2012/06/21 21:00:53]

Nit: Put |'s around |comp2| and |comp1| on this line. Also, please make this
sentence mention comp1 first (in the same order as the parameters, i.e.:

// -1, 0 or 1 if |comp1| is greater than, equal to, or less than |comp2|,

[Mathieu, 2012/06/25 17:00:32]

Done.

+// respectively.
+int CompareVersionComponents(const std::vector<uint16>& comp1,
+                             const std::vector<uint16>& comp2) {
+  size_t count = std::min(comp1.size(), comp2.size());

[Alexei Svitkine (slow), 2012/06/21 21:00:53]

Nit: Make |count| const.

[Mathieu, 2012/06/25 17:00:32]

Done.

+  for (size_t i = 0; i < count; ++i) {
+    if (comp1[i] > comp2[i])
+      return 1;
+    if (comp1[i] < comp2[i])
+      return -1;
+  }
+  if (comp1.size() > comp2.size()) {
+    for (size_t i = count; i < comp1.size(); ++i)
+      if (comp1[i] > 0)
+        return 1;
+  } else if (comp1.size() < comp2.size()) {
+    for (size_t i = count; i < comp2.size(); ++i)
+      if (comp2[i] > 0)
+        return -1;
+  }
+  return 0;
+}
+
+}  // namespace
+
+Version::Version() {
+}
+
+Version::~Version() {
+}
+
+Version::Version(const std::string& version_str) {
+  std::vector<uint16> parsed;
+  if (!ParseVersionNumbers(version_str, parsed))
+    return;
   components_.swap(parsed);
 }
 
@@ -45,6 +85,22 @@
   return (!components_.empty());
 }
 
+// static
+bool Version::IsValidWildcardString(const std::string& wildcard_string) {
+  if (wildcard_string.empty())
+    return false;
+
+  if (wildcard_string.length() == 1 ||

[Alexei Svitkine (slow), 2012/06/21 21:00:53]

You don't need the length == 1 check because EndsWith() will be false in that
case anyway.

[Mathieu, 2012/06/25 17:00:32]

Done.

+      !EndsWith(wildcard_string.c_str(), ".*", false)) {
+    // Either a lone character or a full version number.
+    Version version(wildcard_string);
+    return version.IsValid();
+  }
+  // Version strings length 2 or more, ending with ".*".
+  Version version(wildcard_string.substr(0, wildcard_string.size() - 2));
+  return version.IsValid();
+}
+
 bool Version::IsOlderThan(const std::string& version_str) const {
   Version proposed_ver(version_str);
   if (!proposed_ver.IsValid())
@@ -52,6 +108,37 @@
   return (CompareTo(proposed_ver) < 0);
 }
 
+int Version::CompareToWildcardString(const std::string& wildcard_string) const {
+  DCHECK(IsValid());
+  DCHECK(Version::IsValidWildcardString(wildcard_string));
+
+  // Default behavior if the string doesn't end with a wildcard.
+  if (!EndsWith(wildcard_string.c_str(), ".*", false)) {
+    Version version(wildcard_string);
+    DCHECK(version.IsValid());
+    return CompareTo(version);
+  }
+
+  std::vector<uint16> parsed;
+  bool success = ParseVersionNumbers(

[Alexei Svitkine (slow), 2012/06/21 21:00:53]

Nit: Make |success| const.

[Mathieu, 2012/06/25 17:00:32]

Done.

+      wildcard_string.substr(0, wildcard_str.length() - 2), parsed);
+  DCHECK(success);
+  int comparison = CompareVersionComponents(components_, parsed);

[Alexei Svitkine (slow), 2012/06/21 21:00:53]

Nit: Make |comparison| const.

[Mathieu, 2012/06/25 17:00:32]

Done.

+  if (comparison == -1 || comparison == 0)
+    return comparison;
+
+  // Catch the case where the digits of |parsed| are found in |components_|,
+  // which means that the two are equal since |parsed| has a trailing "*".
+  // (e.g. 1.2.3 vs. 1.2.* will return 0). All other cases return 1 since
+  // components is greater (e.g. 3.2.3 vs 1.*).
+  DCHECK_GT(parsed.size(), 0UL);
+  for (size_t i = 0; i < parsed.size(); ++i) {
+    if (components_[i] != parsed[i])
+      return 1;
+  }
+  return 0;
+}
+
 // TODO(cpu): remove this method.
 Version* Version::GetVersionFromString(const std::string& version_str) {
   Version* vers = new Version(version_str);
@@ -77,23 +164,7 @@
 int Version::CompareTo(const Version& other) const {
   DCHECK(IsValid());
   DCHECK(other.IsValid());
-  size_t count = std::min(components_.size(), other.components_.size());
-  for (size_t i = 0; i < count; ++i) {
-    if (components_[i] > other.components_[i])
-      return 1;
-    if (components_[i] < other.components_[i])
-      return -1;
-  }
-  if (components_.size() > other.components_.size()) {
-    for (size_t i = count; i < components_.size(); ++i)
-      if (components_[i] > 0)
-        return 1;
-  } else if (components_.size() < other.components_.size()) {
-    for (size_t i = count; i < other.components_.size(); ++i)
-      if (other.components_[i] > 0)
-        return -1;
-  }
-  return 0;
+  return CompareVersionComponents(components_, other.components_);
 }
 
 const std::string Version::GetString() const {