Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/metrics/variations_service.cc

Issue 10576003: VariationsService now supports wildcard in min/max version (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/version_unittest.cc ('K') | « base/version_unittest.cc ('k') | chrome/browser/metrics/variations_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/variations_service.cc
===================================================================
--- chrome/browser/metrics/variations_service.cc (revision 142705)
+++ chrome/browser/metrics/variations_service.cc (working copy)
@@ -240,19 +240,13 @@
}
if (filter.has_min_version()) {
- const Version min_version(filter.min_version());
- if (!min_version.IsValid())
+ if (version.CompareToWildcard(filter.min_version()) < 0)
return false;
- if (version.CompareTo(min_version) < 0)
- return false;
}
if (filter.has_max_version()) {
- const Version max_version(filter.max_version());
- if (!max_version.IsValid())
+ if (version.CompareToWildcard(filter.max_version()) > 0)
return false;
- if (version.CompareTo(max_version) > 0)
- return false;
}
return true;
« base/version_unittest.cc ('K') | « base/version_unittest.cc ('k') | chrome/browser/metrics/variations_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698