VariationsService now supports wildcard in min/max version

base/version.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_VERSION_H_
 #define BASE_VERSION_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 12 matching lines @@
   ~Version();
 
   // Initializes from a decimal dotted version number, like "0.1.1".
   // Each component is limited to a uint16. Call IsValid() to learn
   // the outcome.
   explicit Version(const std::string& version_str);
 
   // Returns true if the object contains a valid version number.
   bool IsValid() const;
 
+  // Returns true if the version string is valid. In this version, the string

[Alexei Svitkine (slow), 2012/06/19 18:30:27]

You still have the "In this version" wording which I mentioned I didn't like in
my previous comment. Also, be more precise "e.g. the string may be a valid
version string or a string ending with ".*" wildcard."

[Mathieu, 2012/06/19 20:01:35]

Done. Sorry the updated version did not make it here.

+  // can end with ".*". Any other arrangement with "*" will be invalid (e.g.
+  // 1.*.3 or 1.2.3*).
+  static bool IsValidWildcard(const std::string& version_str);
+
   // Commonly used pattern. Given a valid version object, compare if a
   // |version_str| results in a newer version. Returns true if the
   // string represents valid version and if the version is greater than
   // than the version of this object.
   bool IsOlderThan(const std::string& version_str) const;
 
   // Returns NULL if the string is not in the proper format.
   // Caller is responsible for freeing the Version object once done.
   // DO NOT USE FOR NEWER CODE.
   static Version* GetVersionFromString(const std::string& version_str);
 
   // Creates a copy of this version object. Caller takes ownership.
   // DO NOT USE FOR NEWER CODE.
   Version* Clone() const;
 
   bool Equals(const Version& other) const;
 
   // Returns -1, 0, 1 for <, ==, >.
   int CompareTo(const Version& other) const;
 
+  // Given a valid version object, compare if a |version_str| results in a
+  // newer version. This function will default to CompareTo if the string does
+  // not end in wildcard sequence ".*".
+  int CompareToWildcard(const std::string& version_str) const;
+
   // Return the string representation of this version.
   const std::string GetString() const;
 
   const std::vector<uint16>& components() const { return components_; }
 
  private:
   std::vector<uint16> components_;
 };
 
 #endif  // BASE_VERSION_H_