third_party/re2/README.chromium - Issue 10575037: Include RE2 library

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/re2/README.chromium

Issue 10575037: Include RE2 library (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removed valgrind specific code that is in Chromium already Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 Name: re2 - an efficient, principled regular expression library

	2 Short Name: re2

	3 URL: http://code.google.com/p/re2/
	Mark Mentovai 2012/07/19 16:30:06 Don’t we already have more than one RE library in Don’t we already have more than one RE library in Chrome? What’s the plan for this one? I find it interesting that when I look at this page, the project’s own home site, the last line of the description is: “If you absolutely need backreferences and generalized assertions, then RE2 is not for you, but you might be interested in irregexp, Google Chrome's regular expression engine.” battre 2012/07/19 16:39:06 We have already 2 RE libraries (ICU and one in V8) Show quoted text On 2012/07/19 16:30:06, Mark Mentovai wrote: > Don’t we already have more than one RE library in Chrome? What’s the plan for > this one? > > I find it interesting that when I look at this page, the project’s own home > site, the last line of the description is: > > “If you absolutely need backreferences and generalized assertions, then RE2 is > not for you, but you might be interested in irregexp, Google Chrome's regular > expression engine.” We have already 2 RE libraries (ICU and one in V8). The key difference of this one is: - the algorithm is guaranteed to be linear in the input size (not possible to generate DoS attacks by extension supplied RegEx) - the engine does not generate byte code (a safety concern that allows us to execute extension supplied RegEx in the browser process) I talked to the V8 guys about using the V8 RegEx implementation and it requires a significant setup (it does not work without a V8 context) and has to run in a sandboxed process. Both are significant disadvantages four our use case (using it for extensions; in particular the declarative web request API).
	4 Version: 83:c79416ca4228

	5 Date: 2012-06-20

	6 Revision: 83:c79416ca4228

	7 License: BSD 3-Clause License

	8 License File: LICENSE

	9 Security Critical: yes

	10

	11 Description:

	12 RE2 is a fast, safe, thread-friendly alternative to backtracking regular

	13 expression engines like those used in PCRE, Perl, and Python.

	14

	15 Local Modifications (to be applied in this order):

	16 - Dropped POSIX configuration (remove-posix-option.patch)
	Mark Mentovai 2012/07/24 14:56:29 Do you want to put the patches into their own dire Do you want to put the patches into their own directory for better organization? battre 2012/07/24 16:24:07 Done. Show quoted text On 2012/07/24 14:56:29, Mark Mentovai wrote: > Do you want to put the patches into their own directory for better organization? Done.
	17 - Support for Windows (re2-msvc9-chrome.patch)

	18 - Remove valgrind specific code that exists in chromium already

	19 (remove-valgrind-code.patch)

OLD	NEW

« chrome/chrome_browser.gypi ('K') | « third_party/re2/README ('k') | third_party/re2/benchlog/benchlog.c2 » ('j') | no next file with comments »