Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: content/browser/web_contents/render_view_host_manager_unittest.cc

Issue 10575014: Move process-per-site logic from BrowsingInstance to RenderProcessHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix review comment. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/render_view_host_manager.cc ('k') | content/public/common/content_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/render_view_host_manager_unittest.cc
diff --git a/content/browser/web_contents/render_view_host_manager_unittest.cc b/content/browser/web_contents/render_view_host_manager_unittest.cc
index 2d50c08b2e292a07c4705638d852cd25d8a33e7e..0717818bfcf0498fa67994f52a4a25cdfe0f71d2 100644
--- a/content/browser/web_contents/render_view_host_manager_unittest.cc
+++ b/content/browser/web_contents/render_view_host_manager_unittest.cc
@@ -238,7 +238,7 @@ TEST_F(RenderViewHostManagerTest, NewTabPageProcesses) {
dest_rvh2->GetSiteInstance()));
// Navigate both to the new tab page, and verify that they share a
- // SiteInstance.
+ // RenderProcessHost (not a SiteInstance).
NavigateActiveAndCommit(kNtpUrl);
contents2.GetController().LoadURL(
@@ -249,8 +249,10 @@ TEST_F(RenderViewHostManagerTest, NewTabPageProcesses) {
pending_render_view_host())->SendNavigate(102, kNtpUrl);
dest_rvh2->OnSwapOutACK();
- EXPECT_EQ(active_rvh()->GetSiteInstance(),
- contents2.GetRenderViewHost()->GetSiteInstance());
+ EXPECT_NE(active_rvh()->GetSiteInstance(),
+ contents2.GetRenderViewHost()->GetSiteInstance());
+ EXPECT_EQ(active_rvh()->GetSiteInstance()->GetProcess(),
+ contents2.GetRenderViewHost()->GetSiteInstance()->GetProcess());
}
// Ensure that the browser ignores most IPC messages that arrive from a
« no previous file with comments | « content/browser/web_contents/render_view_host_manager.cc ('k') | content/public/common/content_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698