Simplify fullscreen exit bubble on mac; updating always creates one freshly.

chrome/browser/ui/cocoa/fullscreen_exit_bubble_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/logging.h"  // for NOTREACHED()
 #include "base/mac/bundle_locations.h"
 #include "base/mac/mac_util.h"
 #include "base/sys_string_conversions.h"
@@ skipping 73 matching lines @@
   // The mouselock code expects that mouse events reach the main window
   // immediately, but the cursor is still over the bubble, which eats the
   // mouse events. Make the bubble transparent for mouse events.
   if (bubbleType_ == FEB_TYPE_FULLSCREEN_MOUSELOCK_BUTTONS ||
       bubbleType_ == FEB_TYPE_MOUSELOCK_BUTTONS)
     [[self window] setIgnoresMouseEvents:YES];
 
   DCHECK(fullscreen_bubble::ShowButtonsForType(bubbleType_));
   browser_->OnAcceptFullscreenPermission(
       url_, bubbleType_);
-  [self showButtons:NO];
-  [self hideSoon];

[Nico, 2012/06/20 15:52:11]

Why is this no longer necessary? (This is the bubble fade out animation, right?)

[scheib, 2012/06/20 16:20:34]

OnAcceptFullscreenPermission destroys this object. The new bubble that displays
exit instructions and fades out has hideSoon called in showWindow on line 119.

The philosophy is to avoid having this controller duplicating state transitions
that are owned by the FullscreenController. Instead, this controller should show
any state FullscreenController dictates.

[Nico, 2012/06/20 16:23:36]

Right, but it could reuse the view. That way it's less likely to have a flicker
frame due to no bubble being visible for one frame.

But lgtm anyway.

[scheib, 2012/06/20 16:29:12]

The previous behavior:
- Bubble appears with buttons.
- Click a button.
- Bubble flickers aprox 2 frames as it resizes and lays out into a new bubble
without buttons and with different text.
- Bubble times out and slides off screen.

New behavior:
- Bubble appears with buttons.
- Click a button.
- Bubble instantly disappears and a new bubble rapidly slides down to the same
location without buttons and with different text.
- Bubble times out and slides off screen.

 }
 
 - (void)deny:(id)sender {
   DCHECK(fullscreen_bubble::ShowButtonsForType(bubbleType_));
   browser_->OnDenyFullscreenPermission(bubbleType_);
 }
 
 - (void)showButtons:(BOOL)show {
   [allowButton_ setHidden:!show];
   [denyButton_ setHidden:!show];
@@ skipping 30 matching lines @@
 - (void)positionInWindowAtTop:(CGFloat)maxY width:(CGFloat)maxWidth {
   NSRect windowFrame = [self window].frame;
   NSRect ownerWindowFrame = [owner_ window].frame;
   NSPoint origin;
   origin.x = ownerWindowFrame.origin.x +
       (int)(NSWidth(ownerWindowFrame)/2 - NSWidth(windowFrame)/2);
   origin.y = ownerWindowFrame.origin.y + maxY - NSHeight(windowFrame);
   [[self window] setFrameOrigin:origin];
 }
 
-- (void)updateURL:(const GURL&)url
-       bubbleType:(FullscreenExitBubbleType)bubbleType {
-  bubbleType_ = bubbleType;
-
-  [messageLabel_ setStringValue:[self getLabelText]];
-
-  // Make sure the bubble is visible.
-  [hideAnimation_.get() stopAnimation];
-  [hideTimer_ invalidate];
-  [[[self window] animator] setAlphaValue:1.0];
-
-  if (fullscreen_bubble::ShowButtonsForType(bubbleType)) {
-    [denyButton_ setTitle:SysUTF16ToNSString(
-        fullscreen_bubble::GetDenyButtonTextForType(bubbleType))];
-    [self showButtons:YES];
-
-    // Reenable mouse events if they were disabled previously.
-    [[self window] setIgnoresMouseEvents:NO];
-  } else {
-    [self showButtons:NO];
-    // Only button-less bubbles auto-hide.
-    [self hideSoon];
-  }
-  // TODO(jeremya): show "Press Esc to exit" instead of a link on mouselock.
-
-  // Relayout. A bit jumpy, but functional.
-  [tweaker_ tweakUI:[self window]];
-  [owner_ layoutSubviews];
-}
-
 // Called when someone clicks on the embedded link.
 - (BOOL) textView:(NSTextView*)textView
     clickedOnLink:(id)link
           atIndex:(NSUInteger)charIndex {
   browser_->ExecuteCommand(IDC_FULLSCREEN);
   return YES;
 }
 
 - (void)hideTimerFired:(NSTimer*)timer {
   // This might fire racily for buttoned bubbles, even though the timer is
@@ skipping 141 matching lines @@
 - (void)hideSoon {
   hideTimer_.reset(
       [[NSTimer scheduledTimerWithTimeInterval:kInitialDelay
                                         target:self
                                       selector:@selector(hideTimerFired:)
                                       userInfo:nil
                                        repeats:NO] retain]);
 }
 
 @end