Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: remoting/host/chromoting_host.cc

Issue 10572005: Use SingleThreadTaskRunner instead of MessageLoopProxy in remoting/host. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/host/chromoting_host_context.h » ('j') | remoting/host/chromoting_host_context.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/chromoting_host.cc
diff --git a/remoting/host/chromoting_host.cc b/remoting/host/chromoting_host.cc
index 4aa776801a72b8d364e161182cdb61fb20d4f2ae..9cfe3906fb2ebac28c811ca34287d8e1aa9e0fb9 100644
--- a/remoting/host/chromoting_host.cc
+++ b/remoting/host/chromoting_host.cc
@@ -77,7 +77,7 @@ ChromotingHost::ChromotingHost(
DCHECK(context_);
DCHECK(signal_strategy);
DCHECK(desktop_environment_);
- DCHECK(context_->network_message_loop()->BelongsToCurrentThread());
+ DCHECK(context_->network_task_runner()->BelongsToCurrentThread());
}
ChromotingHost::~ChromotingHost() {
@@ -85,7 +85,7 @@ ChromotingHost::~ChromotingHost() {
}
void ChromotingHost::Start() {
- DCHECK(context_->network_message_loop()->BelongsToCurrentThread());
+ DCHECK(context_->network_task_runner()->BelongsToCurrentThread());
LOG(INFO) << "Starting host";
@@ -100,8 +100,8 @@ void ChromotingHost::Start() {
// This method is called when we need to destroy the host process.
void ChromotingHost::Shutdown(const base::Closure& shutdown_task) {
- if (!context_->network_message_loop()->BelongsToCurrentThread()) {
- context_->network_message_loop()->PostTask(
+ if (!context_->network_task_runner()->BelongsToCurrentThread()) {
+ context_->network_task_runner()->PostTask(
FROM_HERE, base::Bind(&ChromotingHost::Shutdown, this, shutdown_task));
return;
}
@@ -110,7 +110,7 @@ void ChromotingHost::Shutdown(const base::Closure& shutdown_task) {
if (state_ == kInitial || state_ == kStopped) {
// Nothing to do if we are not started.
state_ = kStopped;
- context_->network_message_loop()->PostTask(FROM_HERE, shutdown_task);
+ context_->network_task_runner()->PostTask(FROM_HERE, shutdown_task);
return;
}
if (!shutdown_task.is_null())
@@ -136,12 +136,12 @@ void ChromotingHost::Shutdown(const base::Closure& shutdown_task) {
}
void ChromotingHost::AddStatusObserver(HostStatusObserver* observer) {
- DCHECK(context_->network_message_loop()->BelongsToCurrentThread());
+ DCHECK(context_->network_task_runner()->BelongsToCurrentThread());
status_observers_.AddObserver(observer);
}
void ChromotingHost::RemoveStatusObserver(HostStatusObserver* observer) {
- DCHECK(context_->network_message_loop()->BelongsToCurrentThread());
+ DCHECK(context_->network_task_runner()->BelongsToCurrentThread());
status_observers_.RemoveObserver(observer);
}
@@ -152,14 +152,14 @@ void ChromotingHost::RejectAuthenticatingClient() {
void ChromotingHost::SetAuthenticatorFactory(
scoped_ptr<protocol::AuthenticatorFactory> authenticator_factory) {
- DCHECK(context_->network_message_loop()->BelongsToCurrentThread());
+ DCHECK(context_->network_task_runner()->BelongsToCurrentThread());
session_manager_->set_authenticator_factory(authenticator_factory.Pass());
}
////////////////////////////////////////////////////////////////////////////
// protocol::ClientSession::EventHandler implementation.
void ChromotingHost::OnSessionAuthenticated(ClientSession* client) {
- DCHECK(context_->network_message_loop()->BelongsToCurrentThread());
+ DCHECK(context_->network_task_runner()->BelongsToCurrentThread());
login_backoff_.Reset();
@@ -194,15 +194,15 @@ void ChromotingHost::OnSessionAuthenticated(ClientSession* client) {
}
void ChromotingHost::OnSessionChannelsConnected(ClientSession* client) {
- DCHECK(context_->network_message_loop()->BelongsToCurrentThread());
+ DCHECK(context_->network_task_runner()->BelongsToCurrentThread());
// Then we create a ScreenRecorder passing the message loops that
// it should run on.
Encoder* encoder = CreateEncoder(client->connection()->session()->config());
- recorder_ = new ScreenRecorder(context_->main_message_loop(),
- context_->encode_message_loop(),
- context_->network_message_loop(),
+ recorder_ = new ScreenRecorder(context_->capture_task_runner(),
+ context_->encode_task_runner(),
+ context_->network_task_runner(),
desktop_environment_->capturer(),
encoder);
@@ -216,7 +216,7 @@ void ChromotingHost::OnSessionChannelsConnected(ClientSession* client) {
}
void ChromotingHost::OnSessionAuthenticationFailed(ClientSession* client) {
- DCHECK(context_->network_message_loop()->BelongsToCurrentThread());
+ DCHECK(context_->network_task_runner()->BelongsToCurrentThread());
// Notify observers.
FOR_EACH_OBSERVER(HostStatusObserver, status_observers_,
@@ -224,7 +224,7 @@ void ChromotingHost::OnSessionAuthenticationFailed(ClientSession* client) {
}
void ChromotingHost::OnSessionClosed(ClientSession* client) {
- DCHECK(context_->network_message_loop()->BelongsToCurrentThread());
+ DCHECK(context_->network_task_runner()->BelongsToCurrentThread());
scoped_ptr<ClientSession> client_destroyer(client);
@@ -254,7 +254,7 @@ void ChromotingHost::OnSessionClosed(ClientSession* client) {
void ChromotingHost::OnSessionSequenceNumber(ClientSession* session,
int64 sequence_number) {
- DCHECK(context_->network_message_loop()->BelongsToCurrentThread());
+ DCHECK(context_->network_task_runner()->BelongsToCurrentThread());
if (recorder_.get())
recorder_->UpdateSequenceNumber(sequence_number);
}
@@ -263,14 +263,14 @@ void ChromotingHost::OnSessionRouteChange(
ClientSession* session,
const std::string& channel_name,
const protocol::TransportRoute& route) {
- DCHECK(context_->network_message_loop()->BelongsToCurrentThread());
+ DCHECK(context_->network_task_runner()->BelongsToCurrentThread());
FOR_EACH_OBSERVER(HostStatusObserver, status_observers_,
OnClientRouteChange(session->client_jid(), channel_name,
route));
}
void ChromotingHost::OnSessionManagerReady() {
- DCHECK(context_->network_message_loop()->BelongsToCurrentThread());
+ DCHECK(context_->network_task_runner()->BelongsToCurrentThread());
// Don't need to do anything here, just wait for incoming
// connections.
}
@@ -278,7 +278,7 @@ void ChromotingHost::OnSessionManagerReady() {
void ChromotingHost::OnIncomingSession(
protocol::Session* session,
protocol::SessionManager::IncomingSessionResponse* response) {
- DCHECK(context_->network_message_loop()->BelongsToCurrentThread());
+ DCHECK(context_->network_task_runner()->BelongsToCurrentThread());
if (state_ != kStarted) {
*response = protocol::SessionManager::DECLINE;
@@ -321,15 +321,15 @@ void ChromotingHost::OnIncomingSession(
void ChromotingHost::set_protocol_config(
protocol::CandidateSessionConfig* config) {
- DCHECK(context_->network_message_loop()->BelongsToCurrentThread());
+ DCHECK(context_->network_task_runner()->BelongsToCurrentThread());
DCHECK(config);
DCHECK_EQ(state_, kInitial);
protocol_config_.reset(config);
}
void ChromotingHost::OnLocalMouseMoved(const SkIPoint& new_pos) {
- if (!context_->network_message_loop()->BelongsToCurrentThread()) {
- context_->network_message_loop()->PostTask(
+ if (!context_->network_task_runner()->BelongsToCurrentThread()) {
+ context_->network_task_runner()->PostTask(
FROM_HERE, base::Bind(&ChromotingHost::OnLocalMouseMoved,
this, new_pos));
return;
@@ -342,8 +342,8 @@ void ChromotingHost::OnLocalMouseMoved(const SkIPoint& new_pos) {
}
void ChromotingHost::PauseSession(bool pause) {
- if (!context_->network_message_loop()->BelongsToCurrentThread()) {
- context_->network_message_loop()->PostTask(
+ if (!context_->network_task_runner()->BelongsToCurrentThread()) {
+ context_->network_task_runner()->PostTask(
FROM_HERE, base::Bind(&ChromotingHost::PauseSession, this, pause));
return;
}
@@ -355,8 +355,8 @@ void ChromotingHost::PauseSession(bool pause) {
}
void ChromotingHost::DisconnectAllClients() {
- if (!context_->network_message_loop()->BelongsToCurrentThread()) {
- context_->network_message_loop()->PostTask(
+ if (!context_->network_task_runner()->BelongsToCurrentThread()) {
+ context_->network_task_runner()->PostTask(
FROM_HERE, base::Bind(&ChromotingHost::DisconnectAllClients, this));
return;
}
@@ -369,7 +369,7 @@ void ChromotingHost::DisconnectAllClients() {
}
void ChromotingHost::SetUiStrings(const UiStrings& ui_strings) {
- DCHECK(context_->network_message_loop()->BelongsToCurrentThread());
+ DCHECK(context_->network_task_runner()->BelongsToCurrentThread());
DCHECK_EQ(state_, kInitial);
ui_strings_ = ui_strings;
@@ -392,7 +392,7 @@ Encoder* ChromotingHost::CreateEncoder(const protocol::SessionConfig& config) {
}
void ChromotingHost::StopScreenRecorder() {
- DCHECK(context_->network_message_loop()->BelongsToCurrentThread());
+ DCHECK(context_->network_task_runner()->BelongsToCurrentThread());
DCHECK(recorder_.get());
++stopping_recorders_;
@@ -402,8 +402,8 @@ void ChromotingHost::StopScreenRecorder() {
}
void ChromotingHost::OnScreenRecorderStopped() {
- if (!context_->network_message_loop()->BelongsToCurrentThread()) {
- context_->network_message_loop()->PostTask(
+ if (!context_->network_task_runner()->BelongsToCurrentThread()) {
+ context_->network_task_runner()->PostTask(
FROM_HERE, base::Bind(&ChromotingHost::OnScreenRecorderStopped, this));
return;
}
@@ -416,7 +416,7 @@ void ChromotingHost::OnScreenRecorderStopped() {
}
void ChromotingHost::ShutdownFinish() {
- DCHECK(context_->network_message_loop()->BelongsToCurrentThread());
+ DCHECK(context_->network_task_runner()->BelongsToCurrentThread());
DCHECK(!stopping_recorders_);
state_ = kStopped;
« no previous file with comments | « no previous file | remoting/host/chromoting_host_context.h » ('j') | remoting/host/chromoting_host_context.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698